From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: xen/arm: Assertion 'timer->status >= TIMER_STATUS_inactive' failed at timer.c:279 Date: Wed, 27 Apr 2016 16:05:51 +0200 Message-ID: <1461765951.3525.140.camel@citrix.com> References: <571F7A44.5000705@arm.com> <1461692950.3525.71.camel@citrix.com> <5720C21D.5030402@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8960837699299059313==" Return-path: In-Reply-To: <5720C21D.5030402@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , Julien Grall Cc: Varun.Swara@arm.com, Xen Devel , Steve Capper List-Id: xen-devel@lists.xenproject.org --===============8960837699299059313== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-C3hRJgpnpyChuUFizlAW" --=-C3hRJgpnpyChuUFizlAW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-04-27 at 14:43 +0100, George Dunlap wrote: > On 26/04/16 18:49, Dario Faggioli wrote: > >=C2=A0 > > Let me know, and I'll resubmit the patch properly (together with > > another bugfix I have in my queue). > Yeah, assuming the description in your changeset is accurate, this > seems > like the right approach. >=20 Ok, thanks for having a look, I'll submit a proper series. > The main thing to add here I think is that we need to document what > different circumstances under which the various functions may be > called > -- for instance, in credit1 free_pdata(), it seems to expect that spc > may =3D=3D null at some point.=C2=A0=C2=A0Future schedulers need to know = the > circumstances under which this might happen so they can DTRT. >=20 I saw that too (many times). And in fact, I'm not sure whether that can actually happen or not, but I certainly can look at this. And if by "document what different circumstances under which the various functions may be called" you mean adding comments to that effect somewhere, I'm up for that (I just need to figure out where it would be best to put such comments). > It might be nice at some point to have the alloc / free / init / > deinit > functions in credit1 ordered in a rational way so that they could be > understood by glancing at them, rather than having to jump around, > but > that's probably a nice-to-have clean-up for another time. :-) >=20 When you say "ordered" you mean the order in which they appear in the source file? If yes, I agree, but no, I'm not doing that right now (but I can queue this for when 4.8 opens). Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-C3hRJgpnpyChuUFizlAW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlcgxz8ACgkQk4XaBE3IOsRC5gCfc7luH/KHLaP9BXjjo4T+wRfw hPAAnjGmkpsCi39tgqpzpJHQl8bJLT/1 =jyv6 -----END PGP SIGNATURE----- --=-C3hRJgpnpyChuUFizlAW-- --===============8960837699299059313== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8960837699299059313==--