xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	cardoe@cardoe.com
Subject: [PATCH for-4.7 4/6] blktap2: initialise buf in vhd_util_check_footer
Date: Fri, 29 Apr 2016 16:11:15 +0100	[thread overview]
Message-ID: <1461942677-14564-5-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1461942677-14564-1-git-send-email-wei.liu2@citrix.com>

Gcc complains:

vhd-util-check.c: In function ‘vhd_util_check_footer’:
vhd-util-check.c:413:2: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  memcpy(&backup, buf, sizeof(backup));

In fact buf is initialised a few lines above.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
I can't figure out why buf may be uninitialised and this seems to be the
only way to convince gcc it is ok to proceed.
---
 tools/blktap2/vhd/lib/vhd-util-check.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/blktap2/vhd/lib/vhd-util-check.c b/tools/blktap2/vhd/lib/vhd-util-check.c
index af07426..40565ac 100644
--- a/tools/blktap2/vhd/lib/vhd-util-check.c
+++ b/tools/blktap2/vhd/lib/vhd-util-check.c
@@ -335,7 +335,7 @@ vhd_util_check_footer(int fd, vhd_footer_t *footer, int ignore)
 {
 	size_t size;
 	int err, opened;
-	char *msg, *buf;
+	char *msg, *buf = NULL;
 	off_t eof, off;
 	vhd_footer_t primary, backup;
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-04-29 15:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 15:11 [PATCH for-4.7 0/6] Workaround gcc -Wmaybe-uninitialised false positive reports Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 1/6] rombios/tcgbios: initialise size in tcpa_extend_acpi_log Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 2/6] rombios/tcgbios: initialise entry in HashLogEvent32 Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 3/6] rombios/tcgbios: initialise logdataptr " Wei Liu
2016-04-29 15:11 ` Wei Liu [this message]
2016-04-29 15:11 ` [PATCH for-4.7 5/6] blktap2: initialise buf to NULL in img2qcow.c:main Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 6/6] blktap2: initialise buf in qcow2raw.c:main Wei Liu
2016-05-06 11:15 ` [PATCH for-4.7 0/6] Workaround gcc -Wmaybe-uninitialised false positive reports Wei Liu
2016-05-06 13:37 ` Doug Goldstein
2016-05-06 14:48   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461942677-14564-5-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).