From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH v2 for-4.7 4/6] xen/xsplice: check against ELFOSABI_NONE instead of ELFOSABI_SYSV
Date: Tue, 3 May 2016 12:55:08 +0200 [thread overview]
Message-ID: <1462272910-41200-5-git-send-email-roger.pau@citrix.com> (raw)
In-Reply-To: <1462272910-41200-1-git-send-email-roger.pau@citrix.com>
They are equivalent, but using ELFOSABI_NONE is more correct in this
context.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>
---
xen/common/xsplice_elf.c | 2 +-
xen/include/xen/elfstructs.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/common/xsplice_elf.c b/xen/common/xsplice_elf.c
index e403a0e..1e1f167 100644
--- a/xen/common/xsplice_elf.c
+++ b/xen/common/xsplice_elf.c
@@ -397,7 +397,7 @@ static int xsplice_header_check(const struct xsplice_elf *elf)
if ( hdr->e_version != EV_CURRENT ||
hdr->e_ident[EI_VERSION] != EV_CURRENT ||
hdr->e_ident[EI_ABIVERSION] != 0 ||
- hdr->e_ident[EI_OSABI] != ELFOSABI_SYSV ||
+ hdr->e_ident[EI_OSABI] != ELFOSABI_NONE ||
hdr->e_type != ET_REL ||
hdr->e_phnum != 0 )
{
diff --git a/xen/include/xen/elfstructs.h b/xen/include/xen/elfstructs.h
index 615eb06..68954b0 100644
--- a/xen/include/xen/elfstructs.h
+++ b/xen/include/xen/elfstructs.h
@@ -81,6 +81,7 @@ typedef uint64_t Elf64_Xword;
/* e_ident[] Operating System/ABI */
#define ELFOSABI_SYSV 0 /* UNIX System V ABI */
+#define ELFOSABI_NONE 0 /* Same as ELFOSABI_SYSV */
#define ELFOSABI_HPUX 1 /* HP-UX operating system */
#define ELFOSABI_NETBSD 2 /* NetBSD */
#define ELFOSABI_LINUX 3 /* GNU/Linux */
--
2.6.4 (Apple Git-63)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-03 10:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 10:55 [PATCH v2 for-4.7 0/6] xSplice fixes (+1) Roger Pau Monne
2016-05-03 10:55 ` [PATCH v2 for-4.7 1/6] libxl: add a define for equivalent ENODATA errno on FreeBSD Roger Pau Monne
2016-05-03 11:30 ` Wei Liu
2016-05-03 10:55 ` [PATCH v2 for-4.7 2/6] tools/xsplice: corrently use errno Roger Pau Monne
2016-05-03 11:30 ` Wei Liu
2016-05-03 10:55 ` [PATCH v2 for-4.7 3/6] tools/xsplice: fix mixing system errno values with Xen ones Roger Pau Monne
2016-05-03 11:30 ` Wei Liu
2016-05-03 13:27 ` Konrad Rzeszutek Wilk
2016-05-03 13:29 ` Wei Liu
2016-05-03 13:37 ` Konrad Rzeszutek Wilk
2016-05-04 15:26 ` Wei Liu
2016-05-04 15:57 ` Konrad Rzeszutek Wilk
2016-05-06 8:54 ` Roger Pau Monne
2016-05-03 10:55 ` Roger Pau Monne [this message]
2016-05-03 12:22 ` [PATCH v2 for-4.7 4/6] xen/xsplice: check against ELFOSABI_NONE instead of ELFOSABI_SYSV Andrew Cooper
2016-05-03 14:13 ` Jan Beulich
2016-05-04 7:50 ` Jan Beulich
2016-05-03 10:55 ` [PATCH v2 for-4.7 5/6] xen/xsplice: add ELFOSABI_FREEBSD as a supported OSABI for payloads Roger Pau Monne
2016-05-03 12:21 ` Andrew Cooper
2016-05-03 14:17 ` Jan Beulich
2016-05-04 9:48 ` Roger Pau Monne
2016-05-04 10:34 ` Jan Beulich
2016-05-05 16:35 ` Roger Pau Monne
2016-05-06 6:51 ` Jan Beulich
2016-05-06 12:48 ` Ross Lagerwall
2016-05-06 16:34 ` Konrad Rzeszutek Wilk
2016-05-03 10:55 ` [PATCH v2 for-4.7 6/6] libxl: fix usage of XEN_EOPNOTSUPP Roger Pau Monne
2016-05-03 11:31 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462272910-41200-5-git-send-email-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).