xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH v2 for-4.7 6/6] libxl: fix usage of XEN_EOPNOTSUPP
Date: Tue, 3 May 2016 12:55:10 +0200	[thread overview]
Message-ID: <1462272910-41200-7-git-send-email-roger.pau@citrix.com> (raw)
In-Reply-To: <1462272910-41200-1-git-send-email-roger.pau@citrix.com>

The errno values returned by libxc are already translated into the
underlying OS error space, so it's wrong to compare them against Xen error
codes.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/libxl/libxl_dom_save.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_dom_save.c b/tools/libxl/libxl_dom_save.c
index 076be04..579039f 100644
--- a/tools/libxl/libxl_dom_save.c
+++ b/tools/libxl/libxl_dom_save.c
@@ -386,7 +386,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_save_state *dss)
      */
     ret = xc_domain_getvnuma(CTX->xch, domid, &nr_vnodes, &nr_vmemranges,
                              &nr_vcpus, NULL, NULL, NULL);
-    if (ret != -1 || errno != XEN_EOPNOTSUPP) {
+    if (ret != -1 || errno != EOPNOTSUPP) {
         LOG(ERROR, "Cannot save a guest with vNUMA configured");
         rc = ERROR_FAIL;
         goto out;
-- 
2.6.4 (Apple Git-63)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-05-03 10:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 10:55 [PATCH v2 for-4.7 0/6] xSplice fixes (+1) Roger Pau Monne
2016-05-03 10:55 ` [PATCH v2 for-4.7 1/6] libxl: add a define for equivalent ENODATA errno on FreeBSD Roger Pau Monne
2016-05-03 11:30   ` Wei Liu
2016-05-03 10:55 ` [PATCH v2 for-4.7 2/6] tools/xsplice: corrently use errno Roger Pau Monne
2016-05-03 11:30   ` Wei Liu
2016-05-03 10:55 ` [PATCH v2 for-4.7 3/6] tools/xsplice: fix mixing system errno values with Xen ones Roger Pau Monne
2016-05-03 11:30   ` Wei Liu
2016-05-03 13:27   ` Konrad Rzeszutek Wilk
2016-05-03 13:29     ` Wei Liu
2016-05-03 13:37       ` Konrad Rzeszutek Wilk
2016-05-04 15:26         ` Wei Liu
2016-05-04 15:57           ` Konrad Rzeszutek Wilk
2016-05-06  8:54         ` Roger Pau Monne
2016-05-03 10:55 ` [PATCH v2 for-4.7 4/6] xen/xsplice: check against ELFOSABI_NONE instead of ELFOSABI_SYSV Roger Pau Monne
2016-05-03 12:22   ` Andrew Cooper
2016-05-03 14:13   ` Jan Beulich
2016-05-04  7:50   ` Jan Beulich
2016-05-03 10:55 ` [PATCH v2 for-4.7 5/6] xen/xsplice: add ELFOSABI_FREEBSD as a supported OSABI for payloads Roger Pau Monne
2016-05-03 12:21   ` Andrew Cooper
2016-05-03 14:17   ` Jan Beulich
2016-05-04  9:48     ` Roger Pau Monne
2016-05-04 10:34       ` Jan Beulich
2016-05-05 16:35         ` Roger Pau Monne
2016-05-06  6:51           ` Jan Beulich
2016-05-06 12:48   ` Ross Lagerwall
2016-05-06 16:34     ` Konrad Rzeszutek Wilk
2016-05-03 10:55 ` Roger Pau Monne [this message]
2016-05-03 11:31   ` [PATCH v2 for-4.7 6/6] libxl: fix usage of XEN_EOPNOTSUPP Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462272910-41200-7-git-send-email-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).