From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH for 4.7 4/4] xen: adopt .deinit_pdata and improve timer handling Date: Mon, 9 May 2016 16:52:06 +0200 Message-ID: <1462805526.5968.19.camel@citrix.com> References: <146231184906.25631.6550047090421454264.stgit@Solace.fritz.box> <146231201861.25631.15476137738176988146.stgit@Solace.fritz.box> <1462800130.5968.10.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0282654771695700288==" Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azmXv-0000dt-TK for xen-devel@lists.xenproject.org; Mon, 09 May 2016 14:52:31 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu Cc: "xen-devel@lists.xenproject.org" , Tianyang Chen , Wei Liu , George Dunlap List-Id: xen-devel@lists.xenproject.org --===============0282654771695700288== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-/D5UqdJGOcFnmJD0etl/" --=-/D5UqdJGOcFnmJD0etl/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-05-09 at 10:08 -0400, Meng Xu wrote: > > I don't think things are confusing, neither right now, nor after > > this > > patch, but I'm open to others' opinion. :-) >=20 > Hmm, I won't get confused with the comment from now on, but I'm > unsure > if someone else will or not. The tricky thing is when I know it, I > won't feel weird. However, when I first read it, I feel a little > confusing if not reading the other parts of the code related to this > macro. >=20 I don't feel the same, but I understand the concern. I think we have two options here: =C2=A01. we just do nothing; =C2=A02. you send a patch that, according to your best judgement, improve= =C2=A0 =C2=A0 =C2=A0 things (as we all do all the time! :-P). :-D > Anyway, I'm ok with either way: change the comment or not. >=20 Me too, and in fact, I'm not changing it, but I won't stop you tryingto do so. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-/D5UqdJGOcFnmJD0etl/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXMKQWAAoJEBZCeImluHPuV60P/2qoJYIIXz876xTG8AX9Zqmg 5CzPrwJ9jQjTlPh8gz1FUD4h7EnJZbkoOv+qeNWOtowipXNKTTb7JaLVLUB1U8Go q+iABgQyR/jer/gsG7as5W2scTite1X+9Yp42sVuQlSh+MdpCbdaQvreNeZ+UVhY lQj8D227yr/jzyxFdftmT7P9wRnzWkuAmRkJCfHB1AiNuGgonrzc94TwZWKwBew/ lZojPrxOrKvEm/rPN3A3Yi5YdCYd0e0pnIEvttGIxf6vvlV6gXUQTwY5ESbqF+Qb cW+G+6Cg5P3aHMQUqCNvspS+5LbOftnMMJqoJFgBB7WGzi+tTVewM3oSMDKrf1t0 CtnMcmIpScYlKfclbn/RrG7HvJ/RXfbDDRpM71crGKEYp4LVqPGOXrGE6Klrgj7N 2EIcu/JFVFyOtTfWoNZIZInBOQw3zBO130VqTEuKOpj+Z9TdVZn7+4PfSwo64fdY xIxhFxcKeUYFAdb7p71GRAGDt35yEO9Y7b+mxiUB7VueRxfHNyth0OYECgdY6oQh 56BBv5pxn/UoYo24uiNeKt7ab6Jg6hz1jvyh5gmZ8dz3OAvzPobfED5RpPJUDcpC RyyrtW7Rk18MG20EUd/+ijZFU/HnFXJhgAaUhEdkAjC2wGqCUmBdjqR2Tl8ggt0B EslsyMHKAzjNOGN8uaBz =T9s4 -----END PGP SIGNATURE----- --=-/D5UqdJGOcFnmJD0etl/-- --===============0282654771695700288== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============0282654771695700288==--