* [PATCH] tools: configure correct trace backend for QEMU
@ 2016-05-09 16:43 Paul Durrant
2016-05-10 10:57 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Paul Durrant @ 2016-05-09 16:43 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Paul Durrant, Ian Jackson
Newer versions of the QEMU source have replaced the 'stderr' trace
backend with 'log'. This patch adjusts the tools Makefile to test for
the 'log' backend and specify it if it is available.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile
index 3f45fb9..6440dec 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -240,7 +240,9 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
source=.; \
fi; \
cd qemu-xen-dir; \
- if $$source/scripts/tracetool.py --check-backend --backend stderr ; then \
+ if $$source/scripts/tracetool.py --check-backend --backend log ; then \
+ enable_trace_backend='--enable-trace-backend=log'; \
+ elif $$source/scripts/tracetool.py --check-backend --backend stderr ; then \
enable_trace_backend='--enable-trace-backend=stderr'; \
else \
enable_trace_backend='' ; \
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: configure correct trace backend for QEMU
2016-05-09 16:43 [PATCH] tools: configure correct trace backend for QEMU Paul Durrant
@ 2016-05-10 10:57 ` Wei Liu
2016-05-10 12:38 ` Paul Durrant
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2016-05-10 10:57 UTC (permalink / raw)
To: Paul Durrant; +Cc: xen-devel, Ian Jackson, Wei Liu
On Mon, May 09, 2016 at 05:43:14PM +0100, Paul Durrant wrote:
> Newer versions of the QEMU source have replaced the 'stderr' trace
> backend with 'log'. This patch adjusts the tools Makefile to test for
> the 'log' backend and specify it if it is available.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
I have queued this up for committing for 4.7
Wei.
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 3f45fb9..6440dec 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -240,7 +240,9 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
> source=.; \
> fi; \
> cd qemu-xen-dir; \
> - if $$source/scripts/tracetool.py --check-backend --backend stderr ; then \
> + if $$source/scripts/tracetool.py --check-backend --backend log ; then \
> + enable_trace_backend='--enable-trace-backend=log'; \
> + elif $$source/scripts/tracetool.py --check-backend --backend stderr ; then \
> enable_trace_backend='--enable-trace-backend=stderr'; \
> else \
> enable_trace_backend='' ; \
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: configure correct trace backend for QEMU
2016-05-10 10:57 ` Wei Liu
@ 2016-05-10 12:38 ` Paul Durrant
0 siblings, 0 replies; 3+ messages in thread
From: Paul Durrant @ 2016-05-10 12:38 UTC (permalink / raw)
Cc: xen-devel@lists.xenproject.org, Wei Liu, Ian Jackson
> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@citrix.com]
> Sent: 10 May 2016 11:58
> To: Paul Durrant
> Cc: xen-devel@lists.xenproject.org; Ian Jackson; Wei Liu
> Subject: Re: [PATCH] tools: configure correct trace backend for QEMU
>
> On Mon, May 09, 2016 at 05:43:14PM +0100, Paul Durrant wrote:
> > Newer versions of the QEMU source have replaced the 'stderr' trace
> > backend with 'log'. This patch adjusts the tools Makefile to test for
> > the 'log' backend and specify it if it is available.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> I have queued this up for committing for 4.7
>
Cool. Thanks :-)
Paul
> Wei.
>
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > ---
> > tools/Makefile | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/Makefile b/tools/Makefile
> > index 3f45fb9..6440dec 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -240,7 +240,9 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
> > source=.; \
> > fi; \
> > cd qemu-xen-dir; \
> > - if $$source/scripts/tracetool.py --check-backend --backend stderr ;
> then \
> > + if $$source/scripts/tracetool.py --check-backend --backend log ; then
> \
> > + enable_trace_backend='--enable-trace-backend=log'; \
> > + elif $$source/scripts/tracetool.py --check-backend --backend stderr ;
> then \
> > enable_trace_backend='--enable-trace-backend=stderr'; \
> > else \
> > enable_trace_backend='' ; \
> > --
> > 2.1.4
> >
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-10 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-09 16:43 [PATCH] tools: configure correct trace backend for QEMU Paul Durrant
2016-05-10 10:57 ` Wei Liu
2016-05-10 12:38 ` Paul Durrant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).