From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v1 3/7] mm: Use statically defined locking order Date: Tue, 10 May 2016 10:25:43 +0200 Message-ID: <1462868743.4858.26.camel@citrix.com> References: <1462549688-29263-1-git-send-email-ross.lagerwall@citrix.com> <1462549688-29263-4-git-send-email-ross.lagerwall@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6811088267035686664==" Return-path: In-Reply-To: <1462549688-29263-4-git-send-email-ross.lagerwall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ross Lagerwall , xen-devel@lists.xen.org Cc: George Dunlap , Andrew Cooper , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============6811088267035686664== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-8CEceT0HivCEtAez9HYR" --=-8CEceT0HivCEtAez9HYR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-05-06 at 16:48 +0100, Ross Lagerwall wrote: > Instead of using a locking order based on line numbers which doesn't > play nicely with xSplice, statically define the locking order. >=20 > Signed-off-by: Ross Lagerwall > Reviewed-by: Dario Faggioli FWIW, I actually like this... > --- a/xen/arch/x86/mm/mm-locks.h > +++ b/xen/arch/x86/mm/mm-locks.h > @@ -46,8 +46,10 @@ static inline int mm_locked_by_me(mm_lock_t *l) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return (l->lock.recurse_cpu =3D=3D current-= >processor); > =C2=A0} > =C2=A0 > -/* If you see this crash, the numbers printed are lines in this > file=C2=A0 > - * where the offending locks are declared. */ > +/* > + * If you see this crash, the numbers printed are order levels > defined > + * in this file. > + */ > ... and, apart from the fat that it server xsplice purposes, I'd say this is an improvement on its own of the current situation (although I understand this is a matter of taste). :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-8CEceT0HivCEtAez9HYR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXMZsHAAoJEBZCeImluHPujVEQAMTP/DoX2+adzFvfXiVDIoJR 6UHYh337vVzj9+t/GzhLv7LkC8cBGrfGnb2GF169/b6c2zKh3dWYqt28dLonPgtl D3OQ4LTFeLYbgSiTpNVkkTClGV/2V6dUMh2i4fxtRlH+KjBWxd4IuxiI/J5DBfNf KnOO6pRnXoskUNSNt7/fSvqD7UvtxtNA8N3qHNpIX2vThXGPxXOAw7vHfrJGobUB Y3pNL+JX+VE5h3MVpXb2GgWQtQDHkGQY7WCBjK65e5SjTVE5GIrov5LJgAc1bPl5 wS4hFDr5JTZZhPulp26XGXfyBbOuRXj0+2zizTANaJSDOQw2cypKiALBXxittM9M rhHIPF8vbElPxUojOgQED88n3Ki5mVPZxOU6cpI5rVjWTZ2q9SSRcsCvx1wmnQi/ HmC5uLf1wX4LDWhydy7qGXIqB5fI2I3qDD9x3g42nTU2ZscXZpVO7O3DdzgWY6VT FGvplgZNTgqvLaBejUx+7ZQRTJ3sYaOZy0+zJWxhFHvqBr/SfLWTJ+t3a0bjsq6E Rk+Y25/I7GaE8jgl54OFVjfOO2FxHOIyc75ZN1wqoFhQOThtsSapJbMpxvEJw1qU 3dK2CoiAhv4DJha/CBd7Q/3LhhLdxsMDIrH4x/yR348VmQfry3/W88HsFG/LGQ7X WRkvwoideHw5TVv38xsX =BVvn -----END PGP SIGNATURE----- --=-8CEceT0HivCEtAez9HYR-- --===============6811088267035686664== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============6811088267035686664==--