From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Martin Pohlack <mpohlack@amazon.com>,
ross.lagerwall@citrix.com, "<andrew.cooper3"@citrix.com,
jbeulich@suse.com
Subject: [PATCH] xsplice: Unmask (aka reinstall NMI handler) if we need to abort.
Date: Wed, 11 May 2016 09:59:08 -0400 [thread overview]
Message-ID: <1462975148-25450-1-git-send-email-konrad.wilk@oracle.com> (raw)
If we have to abort in xsplice_spin() we end following
the goto abort. But unfortunataly we neglected to unmask.
This patch fixes that.
Reported-by: Martin Pohlack <mpohlack@amazon.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
Cc: jbeulich@suse.com
Cc: <andrew.cooper3@citrix.com
Cc: ross.lagerwall@citrix.com
Cc: Martin Pohlack <mpohlack@amazon.com>
This has been since v6 posting. v5 posting used the
set_nmi_callback and only used it around the IRQ semaphore.
---
xen/common/xsplice.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
index 21b9ec0..b68875b 100644
--- a/xen/common/xsplice.c
+++ b/xen/common/xsplice.c
@@ -1262,9 +1262,10 @@ void check_for_xsplice_work(void)
arch_xsplice_post_action();
local_irq_restore(flags);
}
- arch_xsplice_unmask();
abort:
+ arch_xsplice_unmask();
+
per_cpu(work_to_do, cpu) = 0;
xsplice_work.do_work = 0;
--
2.5.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-05-11 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 13:59 Konrad Rzeszutek Wilk [this message]
2016-05-11 14:00 ` [PATCH] xsplice: Unmask (aka reinstall NMI handler) if we need to abort Andrew Cooper
2016-05-11 14:05 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462975148-25450-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc="<andrew.cooper3"@citrix.com \
--cc=jbeulich@suse.com \
--cc=mpohlack@amazon.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).