xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, boris.ostrovsky@oracle.com,
	ian.jackson@eu.citrix.com
Subject: [PATCH qemu-traditional] ioreq: Support 32-bit default_ioport_* accesses
Date: Fri, 20 May 2016 09:52:40 -0400	[thread overview]
Message-ID: <1463752360-11311-1-git-send-email-boris.ostrovsky@oracle.com> (raw)

Recent changes in ACPICA (specifically, Linux commit 66b1ed5aa8dd ("ACPICA:
ACPI 2.0, Hardware: Add access_width/bit_offset support for
acpi_hw_write()") result in guests issuing 32-bit accesses to IO space.

QEMU needs to be able to handle them.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 vl.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/vl.c b/vl.c
index c864e7d..79d3ab5 100644
--- a/vl.c
+++ b/vl.c
@@ -350,17 +350,18 @@ static void default_ioport_writew(void *opaque, uint32_t address, uint32_t data)
 
 static uint32_t default_ioport_readl(void *opaque, uint32_t address)
 {
-#ifdef DEBUG_UNUSED_IOPORT
-    fprintf(stderr, "unused inl: port=0x%04x\n", address);
-#endif
-    return 0xffffffff;
+    uint32_t data;
+    data = default_ioport_readw(opaque, address) & 0xffff;
+    address = (address + 2) & (MAX_IOPORTS - 1);
+    data |= default_ioport_readw(opaque, address) << 16;
+    return data;
 }
 
 static void default_ioport_writel(void *opaque, uint32_t address, uint32_t data)
 {
-#ifdef DEBUG_UNUSED_IOPORT
-    fprintf(stderr, "unused outl: port=0x%04x data=0x%02x\n", address, data);
-#endif
+    default_ioport_writew(opaque, address, data & 0xffff);
+    address = (address + 2) & (MAX_IOPORTS - 1);
+    default_ioport_writew(opaque, address, data >> 16);
 }
 
 /* size is the word size in byte */
-- 
1.8.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2016-05-20 13:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 13:52 Boris Ostrovsky [this message]
2016-05-23 12:02 ` [PATCH qemu-traditional] ioreq: Support 32-bit default_ioport_* accesses Wei Liu
2016-05-23 13:02   ` Boris Ostrovsky
2016-05-23 13:05     ` Wei Liu
2016-05-23 13:42 ` Wei Liu
2016-05-25 14:26 ` Ian Jackson
2016-05-25 14:35   ` Ian Jackson
2016-05-25 15:08     ` Boris Ostrovsky
2016-05-25 15:22       ` Ian Jackson
2016-05-25 15:36         ` Boris Ostrovsky
2016-05-25 16:03           ` Jan Beulich
2016-05-25 16:09             ` Ian Jackson
2016-05-25 16:51               ` Boris Ostrovsky
2016-05-25 16:57                 ` Boris Ostrovsky
2016-05-26 14:00                 ` Ian Jackson
2016-05-25 16:02       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463752360-11311-1-git-send-email-boris.ostrovsky@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).