From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config Date: Tue, 7 Jun 2016 19:05:04 +0200 Message-ID: <1465319104.15816.172.camel@citrix.com> References: <1465298642-5356-1-git-send-email-wei.liu2@citrix.com> <1465298642-5356-4-git-send-email-wei.liu2@citrix.com> <20160607144529.GL1184@perard.uk.xensource.com> <20160607160307.GN25922@citrix.com> <1465316547.15816.167.camel@citrix.com> <20160607164627.GU25922@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0555537631075819932==" Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAKRC-0002sK-SA for xen-devel@lists.xenproject.org; Tue, 07 Jun 2016 17:05:10 +0000 In-Reply-To: <20160607164627.GU25922@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Anthony PERARD , Xen-devel , Stefano Stabellini , Ian Jackson , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============0555537631075819932== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-FyoeJYmRQ4tLrAUrOIbd" --=-FyoeJYmRQ4tLrAUrOIbd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-06-07 at 17:46 +0100, Wei Liu wrote: > > > I agree it would be good to set the exact bits though -- if you > > > can > > > tell > > > me which field to test.=C2=A0 > > >=20 > > Perhaps at least mention something about all this either in a > > comment > > or in the changelog? > >=20 > What would you like to see in a comment? I guess this is now moot > because the exact bits will be set. >=20 Well, if the code ends up looking like: "the most correct thing would be to set the proper bits, but it's hard/cumbersome/unknown how to do so, and setting all up until count it enough for making things work" Then, exactly that. :-) If the code does the most correct thing already, as you seem to say, then nothing. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-FyoeJYmRQ4tLrAUrOIbd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXVv7AAAoJEBZCeImluHPut6gP/jCMsdGJraZQaNSkqq5ZS6Iy MOkbPO27wAFaIuwZMYxUIwbAgpulMbiqPTPewqsDi3HUhDOnWCn3vVdWLVatkzK/ 1BBZpj7sUfAnACmGK8bAdXs3zW2fvrCo8T4v9b7AkYsebDtENboGZvbGQvyPqW6I Heu2qFY79Wu1Kp/i+SxsfGtltDKl1R5vHS/lLu0kSf46vQaocj0URI3qevnnL9Yz Dp/j6rwMHHZK7JBXoyYQBmfJfigEUyFDEIJAeOn7OkYTH91lbJPnJoLlsOy/BuZc uyCbXNV7cWjFz9ZAzgUflup2X3Ykp3H+9RbOcIGmc2ckCkub5q3mg6zcMSTMQDSo 1shPXExa0gLGzmHIjGUN2VqQcFo5BG6kmhoeoL0tU1LMxscudbAAKBG6z5A79CWX ZD7u/3f0DZBFxQQhU6i7UyTsOQLC0IDTkPxjXl5my7LWCcERoo+C75NT6dXQl5yd WhbyhxL9t6yQqZnyK9pjXWIq1QZz94kEUqadvXP0OZ6i6x5JVD0MBDQe1G4dcQ8i OdYyHvYN6UaLXoo+hVY4qAxj8DuF67C45ld5Dj1CqXje/bjKHA3pg7YsdyYt6QI9 MUFzcg+nD4ssDbgYRdhx3qmjavCnrHd/CS3CzVvcF/qdHcDVIAxAK1WDc2pU7pjz rRnCrs2Cd7tb0VfQ/ihp =zBdk -----END PGP SIGNATURE----- --=-FyoeJYmRQ4tLrAUrOIbd-- --===============0555537631075819932== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============0555537631075819932==--