From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 18/19] xen: credit2: implement SMT support independent runq arrangement Date: Mon, 20 Jun 2016 12:38:35 +0200 Message-ID: <1466419115.19253.1.camel@citrix.com> References: <146620492155.29766.10321123657058307698.stgit@Solace.fritz.box> <146620520979.29766.17431818083809592415.stgit@Solace.fritz.box> <5767C4D602000078000F682E@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8657776027841575518==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEwdw-0002uA-Sw for xen-devel@lists.xenproject.org; Mon, 20 Jun 2016 10:41:24 +0000 In-Reply-To: <5767C4D602000078000F682E@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Anshul Makkar , David Vrabel , George Dunlap List-Id: xen-devel@lists.xenproject.org --===============8657776027841575518== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Xw3mhU1ksyU1uGWAMsSm" --=-Xw3mhU1ksyU1uGWAMsSm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-06-20 at 02:26 -0600, Jan Beulich wrote: > > > > On 18.06.16 at 01:13, wrote: > > +static inline > > +void smt_idle_mask_set(unsigned int cpu, cpumask_t *idlers, > > cpumask_t *mask) > > +{ > > +=C2=A0=C2=A0=C2=A0=C2=A0if ( cpumask_subset( per_cpu(cpu_sibling_mask,= cpu), idlers) ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cpumask_or(mask, mask,= per_cpu(cpu_sibling_mask, cpu)); > > +} > I think helpers like this should be made const-correct. Here idlers > is only an input. >=20 Ok. > Also I'm not sure the compiler can fold the redundant > per_cpu(cpu_sibling_mask, cpu) in all cases. Is it maybe worth > helping it by using a local variable here or moving the expression > into the caller's invocation expression? >=20 Agreed too. > > @@ -945,6 +1034,7 @@ runq_tickle(const struct scheduler *ops, > > struct csched2_vcpu *new, s_time_t now) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(unsigned char *)&= d); > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__cpumask_set_cpu(ipid, &rqd->tickled); > > +=C2=A0=C2=A0=C2=A0=C2=A0//smt_idle_mask_clear(ipid, &rqd->smt_idle); X= XX > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cpu_raise_softirq(ipid, SCHEDULE_SOFTIRQ)= ; > > =C2=A0} > With this, was the patch meant to be RFC? >=20 No, it's me that should have removed this line after the last round of testing, but forgot. Apologies. :-/ > > @@ -1435,13 +1525,15 @@ csched2_cpu_pick(const struct scheduler > > *ops, struct vcpu *vc) > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if ( !read_trylock(&prv->lock) ) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* We may be here beca= use someon requested us to migrate > > */ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* We may be here beca= use someone requested us to migrate > > */ > Please add the missing full stop at once. >=20 Yep. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Xw3mhU1ksyU1uGWAMsSm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXZ8erAAoJEBZCeImluHPuqhkP/RsnYr0ETHUfti47OC0/WJ7d N4AyQdI7vf7g/b2QfnttoNaKQD6PQOKtWQL+eNiIa3PqpDwKWTVOkYZ6/bQNXkH0 UOAkB6nYcm/si1wmmIx4zGRC67mKQroV7JJP82rhw2/TA/KuNXwUKv+V36Yz8MPU Go8/o1DGa3siecGsKKU3UqAHs5CeKNDxPkHSdigMKZ32J9udlkEV0fnnh9I7Gb/X lvBEEja0Zt8/oz+9cbpGHm1xix/GLm9pgeGsx9Ys4eGfsIl2Rxz1tK/Rk2oUuN5H DBMulT66vYnR9sLSqzkuX1Kb9rUvl3boM/cQEa+Xw7wXH46wi1c4z87KEa1ZnPD/ oiapJixD1X/BFD+63FQkzoXFeavc4jxj+ugKfUBRAmZuGbuSK5PEqjYibHUk7MHz TZ8xYVL5XfTSOO4ROA/VlPyUFenDQSr11GfmEeZ2Fr3Zbb0yGCwxqcNq3HxLfbxr RD8Q75e8KxXcWPOCnZhL1+aML/dEwW8xPnFq2+YUjz/qD+iwx+bvg2E1Kf3iigfz /sHgXGwd9UaGbAcs5ntGijcQZ703TVGKKycASVblA91WWYml8kpZhrsfmMGrye/k 32H6NmVvbWaqxU+bQngKxvOrFOZ3qTmAMOsVw91207Nh5HUx0PEWh5DklMk+JqFr 900azV/MDeMkfuOaqN0m =SQiB -----END PGP SIGNATURE----- --=-Xw3mhU1ksyU1uGWAMsSm-- --===============8657776027841575518== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8657776027841575518==--