From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 00/19] Assorted fixes and improvements to Credit2 Date: Mon, 20 Jun 2016 13:43:45 +0200 Message-ID: <1466423025.19253.43.camel@citrix.com> References: <146618450041.23516.9007927860063823148.stgit@Solace.fritz.box> <5767BAAD02000078000F67CA@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4377635808004953314==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bExcZ-00005K-Ei for xen-devel@lists.xenproject.org; Mon, 20 Jun 2016 11:44:03 +0000 In-Reply-To: <5767BAAD02000078000F67CA@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , xen-devel@lists.xenproject.org, Anshul Makkar , David Vrabel List-Id: xen-devel@lists.xenproject.org --===============4377635808004953314== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-95rynV9I0XAS0fJCJy7p" --=-95rynV9I0XAS0fJCJy7p Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-06-20 at 01:43 -0600, Jan Beulich wrote: > >=20 > > >=20 > > > >=20 > > > > On 17.06.16 at 19:32, wrote: > > > -------------------------------------|-------------------------------= --| > > > Xen build, high VM load, with noise | Iperf, high VM load, with noise= | > > > -------------------------------------|-------------------------------= --| > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0run= q=3Dcore=C2=A0=C2=A0=C2=A0runq=3Dsocket=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0runq=3Dcore runq=3Dsocket | > > > baseline=C2=A0=C2=A0=C2=A0=C2=A0=C2=A041.466=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A030.630=C2=A0=C2=A0=C2=A0=C2=A0| baseline=C2=A0=C2=A0=C2= =A0=C2=A020.333=C2=A0=C2=A0=C2=A0=C2=A0=C2=A020.633=C2=A0=C2=A0=C2=A0| > > > patched=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A036.840=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A029.080=C2=A0=C2=A0=C2=A0=C2=A0| patched=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A019.967=C2=A0=C2=A0=C2=A0=C2=A0=C2=A021.000=C2=A0=C2=A0=C2= =A0| > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D| > > Which, summarizing, means: > > =C2=A0* as far as Credit2 is concerned,=C2=A0=C2=A0applying this series= and using > > runq=3Dsocket > > =C2=A0=C2=A0=C2=A0is what _ALWAYS_ provides the best results. > Always? What about the increase on far the right side of the above > table fragment? It's not a big change, but anyway. >=20 Not sure I follow. By 'far the right side' you mean the results of "Iperf, high VM load, with noise"? If yes, the 'patched' and 'runq=3Dsocket' element shows the highest value, which in this case is a good thing, because this is Iperf and the number is the total throughput in Gbps, and the higher it is, the better. > > [*] Jan, I confirm that, with your series applied, I haven't yet > > seen any of > > those "Time went backwards?" printk from Credit2, as you sort of > > were > > expecting... > Well, that's better than I had expected then: I didn't really think > they would be gone entirely. How long of an uptime did your tests > cover? As noted in the cover letter, I've observed remaining odd > TSC/stime jumps to increase in range over time, with no explanation > so far. >=20 The total uptime of one run of this benchmarks is a handful of minutes, so that's probably why I don't see any problem. > Also I wonder whether I may translate your statement above to > a Tested-by for part or all of the series (right now there's only a > coding style fix to one of the patches and a slight extension to > the rdtsc_ordered() one pending for an eventual v2). >=20 Indeed you can... I was in fact planning to reply directly to the series' thread with that. I've applied, and hence tested, the full series. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-95rynV9I0XAS0fJCJy7p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXZ9bxAAoJEBZCeImluHPuy2QP/RTKv3sf3SSHo2p6P7Vd5vya WEpclEjJUkXXpuXLSx39Clk8McdwbhTpBNYqxTwY393KP8lzEAi6PjxAvmgavpq8 RbzA8GO85Y+DPLgHNdoZkTvFnOldK8Fe16/WZ1FeiEX0XokDnIKNUi6Z5C/nhaCj h7vLb/fObDj0/iLy+dzyb+kPSuvg1OOQVLmFLH9colpfkUP01kF+0GXtBq3hPlQ8 FfoV5s+wta7gfNYu4W2G9kfhf4fnni0ukkBrgyzshbHy1D9zO/qtkjiAgFMa0OWP pry+Wf4Miy2IDMtdZNhGzZ7qdWnKJ2NDlXPmhSz3pKX0SRl3GSEepf44PIbL2cs2 IsxFMMwTFxb9PM3d4nI3qSVa3ybT9Bkoc/dwZtvaqbAIvelfFU1WuMEAPm7bGoLX k1iH1sgD2o1yxwjH1p/FfCMWYPxKRb+BHMQ5U4ciJiiwfGbptq/675psFtmIzFJZ USmWeyVB7R08g8AM4NZZQeEis1oVhxplzcK+2sb6dQRpZ84YW9hUBQjPSaJax/Gb VS0XVLK3qdd76AO1z30l+ehIKd0N5PMMIZ58FpuhGBydNptRQczN3dm3J9BO9yne K0kDgYNTV1XtkmgCQ96yf88wcUfF2GmuW0P1P3E3EgHnzivZnlN8zGPN1dq9Wm3b B6rg7yagXgNC8OP27lnt =2Em9 -----END PGP SIGNATURE----- --=-95rynV9I0XAS0fJCJy7p-- --===============4377635808004953314== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============4377635808004953314==--