From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 1/3] xen: add warning infrastructure
Date: Mon, 20 Jun 2016 17:30:23 +0100 [thread overview]
Message-ID: <1466440225-4161-2-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1466440225-4161-1-git-send-email-wei.liu2@citrix.com>
Use an array to keep track of warning text, provide a function to add
warning text to track. Print warnings (if any) right before finishing
using the console.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/arch/x86/setup.c | 3 +++
xen/common/Makefile | 1 +
xen/common/warning.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++
xen/include/xen/warning.h | 7 +++++++
4 files changed, 61 insertions(+)
create mode 100644 xen/common/warning.c
create mode 100644 xen/include/xen/warning.h
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6f6a6a7..3ef8c43 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -28,6 +28,7 @@
#include <xen/tmem_xen.h>
#include <xen/virtual_region.h>
#include <xen/watchdog.h>
+#include <xen/warning.h>
#include <public/version.h>
#include <compat/platform.h>
#include <compat/xen.h>
@@ -1582,6 +1583,8 @@ void __init noreturn __start_xen(unsigned long mbi_p)
init_constructors();
+ warning_print();
+
console_endboot();
/* Hide UART from DOM0 if we're using it */
diff --git a/xen/common/Makefile b/xen/common/Makefile
index e9893e2..600b5ce 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -59,6 +59,7 @@ obj-y += vm_event.o
obj-y += vmap.o
obj-y += vsprintf.o
obj-y += wait.o
+obj-y += warning.o
obj-$(CONFIG_XENOPROF) += xenoprof.o
obj-y += xmalloc_tlsf.o
diff --git a/xen/common/warning.c b/xen/common/warning.c
new file mode 100644
index 0000000..8a3e904
--- /dev/null
+++ b/xen/common/warning.c
@@ -0,0 +1,50 @@
+#include <xen/delay.h>
+#include <xen/init.h>
+#include <xen/lib.h>
+#include <xen/softirq.h>
+#include <xen/warning.h>
+
+#define WARNING_ARRAY_SIZE 20
+static unsigned int __initdata nr_warnings;
+static const char __initdata *warnings[WARNING_ARRAY_SIZE];
+
+void __init warning_add(const char *warning)
+{
+ if ( nr_warnings >= WARNING_ARRAY_SIZE )
+ panic("Too many pieces of warning text.");
+
+ warnings[nr_warnings] = warning;
+ nr_warnings++;
+}
+
+void __init warning_print(void)
+{
+ unsigned int i, j;
+
+ if ( !nr_warnings )
+ return;
+
+ for ( i = 0; i < nr_warnings; i++ )
+ printk("%s", warnings[i]);
+
+ for ( i = 0; i < 3; i++ )
+ {
+ printk("%u... ", 3 - i);
+ for ( j = 0; j < 100; j++ )
+ {
+ process_pending_softirqs();
+ mdelay(10);
+ }
+ }
+ printk("\n");
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/xen/warning.h b/xen/include/xen/warning.h
new file mode 100644
index 0000000..c0661d5
--- /dev/null
+++ b/xen/include/xen/warning.h
@@ -0,0 +1,7 @@
+#ifndef _WARNING_H_
+#define _WARNING_H_
+
+void warning_add(const char *warning);
+void warning_print(void);
+
+#endif
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-20 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 16:30 [PATCH v3 0/3] Make hvm_fep available to non-debug build Wei Liu
2016-06-20 16:30 ` Wei Liu [this message]
2016-06-22 15:35 ` [PATCH v3 1/3] xen: add warning infrastructure Jan Beulich
2016-06-23 10:37 ` Wei Liu
2016-06-23 11:17 ` Wei Liu
2016-06-23 11:21 ` Andrew Cooper
2016-06-23 12:18 ` Jan Beulich
2016-06-20 16:30 ` [PATCH v3 2/3] console: use warning infrastructure for sync console warning Wei Liu
2016-06-22 15:37 ` Jan Beulich
2016-06-23 10:45 ` Wei Liu
2016-06-20 16:30 ` [PATCH v3 3/3] xen: make available hvm_fep to non-debug build as well Wei Liu
2016-06-22 15:42 ` Jan Beulich
2016-06-23 10:50 ` Wei Liu
2016-06-23 12:20 ` Jan Beulich
2016-06-23 12:44 ` Wei Liu
2016-06-23 12:48 ` Andrew Cooper
2016-06-23 12:50 ` Wei Liu
2016-06-23 13:05 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466440225-4161-2-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).