From: Julien Grall <julien.grall@arm.com>
To: xen-devel@lists.xen.org
Cc: andre.przywara@arm.com, Julien Grall <julien.grall@arm.com>,
sstabellini@kernel.org, steve.capper@arm.com,
wei.chen@linaro.org
Subject: [PATCH 3/9] xen/arm: traps: Data Abort are always unconditional
Date: Wed, 22 Jun 2016 14:21:03 +0100 [thread overview]
Message-ID: <1466601669-25398-4-git-send-email-julien.grall@arm.com> (raw)
In-Reply-To: <1466601669-25398-1-git-send-email-julien.grall@arm.com>
The HSR encoding for an exception from a data abort does not contain a
conditional code (see G6-4264 in ARM DDI 0487A.i) because they are
always conditional.
So drop the pointless condition check.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/traps.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 742f7d3..2e84b5a 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -2435,12 +2435,6 @@ static void do_trap_data_abort_guest(struct cpu_user_regs *regs,
int rc;
mmio_info_t info;
- if ( !check_conditional_instr(regs, hsr) )
- {
- advance_pc(regs, hsr);
- return;
- }
-
info.dabt = dabt;
#ifdef CONFIG_ARM_32
info.gva = READ_CP32(HDFAR);
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-22 13:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 13:21 [PATCH 0/9] xen/arm: Simplify do_trap_*_abort_guest Julien Grall
2016-06-22 13:21 ` [PATCH 1/9] xen/arm: Simply the definition of PAGE_SIZE by using the macro _AC Julien Grall
2016-07-14 11:02 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 2/9] xen/arm: traps: Second attempt to correctly use the content of HPFAR_EL2 Julien Grall
2016-07-14 11:05 ` Stefano Stabellini
2016-06-22 13:21 ` Julien Grall [this message]
2016-07-14 11:06 ` [PATCH 3/9] xen/arm: traps: Data Abort are always unconditional Stefano Stabellini
2016-06-22 13:21 ` [PATCH 4/9] xen/arm: traps: Simplify the switch in do_trap_*_abort_guest Julien Grall
2016-07-14 11:12 ` Stefano Stabellini
2016-07-14 11:17 ` Julien Grall
2016-07-14 13:43 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 5/9] xen/arm: Provide macros to help creating workaround helpers Julien Grall
2016-07-14 13:57 ` Stefano Stabellini
2016-07-20 12:43 ` Julien Grall
2016-07-22 15:05 ` Konrad Rzeszutek Wilk
2016-06-22 13:21 ` [PATCH 6/9] xen/arm: Use check_workaround to handle the erratum 766422 Julien Grall
2016-07-14 14:34 ` Stefano Stabellini
2016-07-14 14:39 ` Julien Grall
2016-06-22 13:21 ` [PATCH 7/9] xen/arm: traps: MMIO should only be emulated for fault translation Julien Grall
2016-07-14 15:06 ` Stefano Stabellini
2016-07-14 15:23 ` Julien Grall
2016-07-14 15:28 ` Stefano Stabellini
2016-07-14 15:29 ` Julien Grall
2016-06-22 13:21 ` [PATCH 8/9] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers Julien Grall
2016-07-14 15:27 ` Stefano Stabellini
2016-07-14 15:31 ` Julien Grall
2016-07-14 15:35 ` Stefano Stabellini
2016-06-22 13:21 ` [PATCH 9/9] xen/arm: arm64: Add Cortex-A57 erratum 834220 workaround Julien Grall
2016-07-14 15:31 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466601669-25398-4-git-send-email-julien.grall@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=sstabellini@kernel.org \
--cc=steve.capper@arm.com \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).