From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 13/19] xen: credit2: make the code less experimental Date: Thu, 7 Jul 2016 12:59:25 +0200 Message-ID: <1467889165.23985.68.camel@citrix.com> References: <146620492155.29766.10321123657058307698.stgit@Solace.fritz.box> <146620517107.29766.17643295412098867216.stgit@Solace.fritz.box> <5767C1D802000078000F6812@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7364863339614613439==" Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL721-0005Ad-JE for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 10:59:45 +0000 In-Reply-To: <5767C1D802000078000F6812@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Anshul Makkar , David Vrabel , George Dunlap List-Id: xen-devel@lists.xenproject.org --===============7364863339614613439== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-J5l6DclzdcjLWzoQfIX1" --=-J5l6DclzdcjLWzoQfIX1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-06-20 at 02:13 -0600, Jan Beulich wrote: > > > > On 18.06.16 at 01:12, wrote: > > @@ -680,8 +677,8 @@ __update_svc_load(const struct scheduler *ops, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0delta =3D now - s= vc->load_last_update; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if ( unlikely(del= ta < 0) ) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0d2printk("%s: Time went backwards? now %"PRI_stime" > > llu %"PRI_stime"\n", > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__func__, now, svc= ->load_last_update); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0printk("WARNING: %s: Time went backwards? now > > %"PRI_stime" llu %"PRI_stime"\n", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__func__, now, svc->load_last_= update); > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0delta =3D 0; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > =C2=A0 > With these now becoming non-debugging ones - are they useful > _every_ time such an event occurs? I.e. wouldn't it be better to > e.g. only log new high watermark values? > Actually, I may want to reconsider this specific hunk (and the other similar ones using printk instead of d2printk for 'time going backwards' debug lines). It's useful, but I'm not sure I want it printing all the time. So hold off committing this patch, please (this is probably not necessary to say, given the issue below, but just in case...) > > @@ -2580,15 +2583,20 @@ csched2_init(struct scheduler *ops) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int i; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct csched2_private *prv; > > =C2=A0 > > -=C2=A0=C2=A0=C2=A0=C2=A0printk("Initializing Credit2 scheduler\n" \ > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0" WA= RNING: This is experimental software in > > development.\n" \ > > +=C2=A0=C2=A0=C2=A0=C2=A0printk("Initializing Credit2 scheduler\n"); > > +=C2=A0=C2=A0=C2=A0=C2=A0printk(" WARNING: This is experimental softwar= e in > > development.\n" \ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0" Use at your own risk.\n"); > > =C2=A0 > > -=C2=A0=C2=A0=C2=A0=C2=A0printk(" load_precision_shift: %d\n", > > opt_load_precision_shift); > > -=C2=A0=C2=A0=C2=A0=C2=A0printk(" load_window_shift: %d\n", opt_load_wi= ndow_shift); > > -=C2=A0=C2=A0=C2=A0=C2=A0printk(" underload_balance_tolerance: %d\n", > > opt_underload_balance_tolerance); > > -=C2=A0=C2=A0=C2=A0=C2=A0printk(" overload_balance_tolerance: %d\n", > > opt_overload_balance_tolerance); > > -=C2=A0=C2=A0=C2=A0=C2=A0printk(" runqueues arrangement: %s\n", > > opt_runqueue_str[opt_runqueue]); > > +=C2=A0=C2=A0=C2=A0=C2=A0printk(XENLOG_INFO " load_precision_shift: %d\= n" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0" lo= ad_window_shift: %d\n" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0" un= derload_balance_tolerance: %d\n" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0" ov= erload_balance_tolerance: %d\n" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0" ru= nqueues arrangement: %s\n", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0opt_= load_precision_shift, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0opt_= load_window_shift, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0opt_= underload_balance_tolerance, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0opt_= overload_balance_tolerance, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0opt_= runqueue_str[opt_runqueue]); > Note that this results in only the first line getting logged at info > level; > all others will get the default logging level (i.e. warning) > assigned. IOW > I think you want to repeat XENLOG_INFO a couple of times. >=20 You know what, I did not notice that, sorry! Yes, I'll fix this. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-J5l6DclzdcjLWzoQfIX1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXfjYNAAoJEBZCeImluHPuVywQANFJKr2fnb7xA0bun47mYbS9 Tg0NRWNmazT5HQyzvUgTqQe8e9SHp7pv0pzPVo8nWE8VQduMeFNZAO4phvHFWQRs 1ErO34gHKvyAhYbiE+PYCX8im2qSMdxHbRXioSdf/EaO9hW9wreU4/gleEaYpDoe yN5dxfk1EhCFwvSQNlFdjbzVJ1vp1J7Eh8Ie/GjO3a4XK1JMqzQRp1ruvxhv2Osf 79I0qaZUQsVKMagXFF1LiY7Fs/Uw9R2HcAQ2r66mjqOGi0Win4gDp2/TTz4ecfib ny6zlgaknY0BubwT9/idocIJNiQhZX0MBanJNnwcwQyj09SfGFHvisw+Jk+xNlrG N2EFxs9PAhEVeQvVyt7PFlnOVZHd4AYb1sB4k57yh4ooBbs5fbzBNgeWTrzJf9xw Ut2CxFK18fk8s/YwkHIvmCf8TpdTqzaDYqWxaa5YfkYJHXQmHnfkqELVKvtt/wTS O0GihmzFYuhPmB6+zIskzSvtJGyOfVN0DD7QkOgPQfnfOoGBSEGN3EHVaDPwg4Qo k0MACGUABUR2FIp+IPh+PgMYRy6YqeBy2HeCyu59lnkq9fJsAJcUoMYMDnKHalpk e8OM0MdZS4xeSQh24JtjeZSK2gqpTTiE+qwVLD3kStmAFhojG6bLUP+6zdVrY0XX XTOas74q5f1V/C4a919z =bijh -----END PGP SIGNATURE----- --=-J5l6DclzdcjLWzoQfIX1-- --===============7364863339614613439== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7364863339614613439==--