From: Julien Grall <julien.grall@arm.com>
To: xen-devel@lists.xen.org
Cc: Julien Grall <julien.grall@arm.com>,
sstabellini@kernel.org, Shannon Zhao <shannon.zhao@linaro.org>
Subject: [PATCH v7 07/14] xen/arm: map_regions_rw_cache: Map the region with p2m->default_access
Date: Tue, 12 Jul 2016 14:59:28 +0100 [thread overview]
Message-ID: <1468331975-27331-8-git-send-email-julien.grall@arm.com> (raw)
In-Reply-To: <1468331975-27331-1-git-send-email-julien.grall@arm.com>
The parameter 'access' is used by memaccess to restrict temporarily the
permission. This parameter should not be used for other purpose (such
as restricting permanently the permission).
Instead, we should use the default access requested by memacess. When it
is not enabled, the access will be p2m_access_rwx (i.e no restriction
applied).
The type p2m_mmio_direct will map the region read-write and
non-executable before any further restriction by memaccess. Note that
this is already the resulting permission with the curreent combination
of the type and the access. So there is no functional change.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
Cc: Shannon Zhao <shannon.zhao@linaro.org>
This patch is a candidate for Xen 4.7. Currently this function is
only used to map ACPI regions.
I am wondering if we should introduce a new p2m type for it. And map
this region RO (I am not sure why a guest would want to
modify this region).
Changes in v2:
- Reword the commit message
Changes in v4:
- Patch added
---
xen/arch/arm/p2m.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 1cfb62b..fcc4513 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1231,7 +1231,7 @@ int map_regions_rw_cache(struct domain *d,
pfn_to_paddr(start_gfn + nr),
pfn_to_paddr(mfn),
MATTR_MEM, 0, p2m_mmio_direct,
- p2m_access_rw);
+ d->arch.p2m.default_access);
}
int unmap_regions_rw_cache(struct domain *d,
@@ -1244,7 +1244,7 @@ int unmap_regions_rw_cache(struct domain *d,
pfn_to_paddr(start_gfn + nr),
pfn_to_paddr(mfn),
MATTR_MEM, 0, p2m_invalid,
- p2m_access_rw);
+ d->arch.p2m.default_access);
}
int map_mmio_regions(struct domain *d,
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-12 13:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 13:59 [PATCH v7 00/14] xen/arm: Use the typesafes gfn and mfn Julien Grall
2016-07-12 13:59 ` [PATCH v7 01/14] xen: Use the typesafe mfn and gfn in map_mmio_regions Julien Grall
2016-07-12 16:45 ` George Dunlap
2016-07-12 13:59 ` [PATCH v7 02/14] xen/passthrough: x86: Use INVALID_GFN rather than INVALID_MFN Julien Grall
2016-07-12 13:59 ` [PATCH v7 03/14] xen: Use a typesafe to define INVALID_MFN Julien Grall
2016-07-12 17:04 ` George Dunlap
2016-07-13 8:24 ` Tim Deegan
2016-07-13 0:11 ` Tian, Kevin
2016-07-12 13:59 ` [PATCH v7 04/14] xen: Use a typesafe to define INVALID_GFN Julien Grall
2016-07-12 17:12 ` George Dunlap
2016-07-13 0:13 ` Tian, Kevin
2016-07-12 13:59 ` [PATCH v7 05/14] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn Julien Grall
2016-07-12 13:59 ` [PATCH v7 06/14] xen/arm: Rework the interface of p2m_cache_flush and use typesafe gfn Julien Grall
2016-07-12 13:59 ` Julien Grall [this message]
2016-07-13 17:34 ` [PATCH v7 07/14] xen/arm: map_regions_rw_cache: Map the region with p2m->default_access Stefano Stabellini
2016-07-12 13:59 ` [PATCH v7 08/14] xen/arm: dom0_build: Remove dead code in allocate_memory Julien Grall
2016-07-12 13:59 ` [PATCH v7 09/14] xen/arm: p2m: Remove unused operation ALLOCATE Julien Grall
2016-07-12 13:59 ` [PATCH v7 10/14] xen/arm: Use the typesafes mfn and gfn in map_dev_mmio_region Julien Grall
2016-07-13 17:37 ` Stefano Stabellini
2016-07-12 13:59 ` [PATCH v7 11/14] xen/arm: Use the typesafes mfn and gfn in map_regions_rw_cache Julien Grall
2016-07-12 13:59 ` [PATCH v7 12/14] xen/arm: p2m: Introduce helpers to insert and remove mapping Julien Grall
2016-07-13 17:51 ` Stefano Stabellini
2016-07-12 13:59 ` [PATCH v7 13/14] xen/arm: p2m: Use typesafe gfn for {max, lowest}_mapped_gfn Julien Grall
2016-07-12 13:59 ` [PATCH v7 14/14] xen/arm: p2m: Rework the interface of apply_p2m_changes and use typesafe Julien Grall
2016-07-13 17:50 ` Stefano Stabellini
2016-07-13 13:13 ` [PATCH v7 00/14] xen/arm: Use the typesafes gfn and mfn Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468331975-27331-8-git-send-email-julien.grall@arm.com \
--to=julien.grall@arm.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).