xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 4/4] build_clone: Move git_massage_url to build_url_vcs
Date: Tue, 12 Jul 2016 18:40:23 +0100	[thread overview]
Message-ID: <1468345223-6457-5-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1468345223-6457-1-git-send-email-ian.jackson@eu.citrix.com>

The effect is that ts-xen-build (the only other caller of
build_url_vcs) now gets the massaged rather than unmassaged urls.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/TestSupport.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 485a29a..d0d6ef3 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -1287,6 +1287,10 @@ sub build_url_vcs ($) {
 	}
     }
 
+    if (($vcs // '<unknown>') eq 'git') {
+	$tree = git_massage_url($tree);
+    }
+
     return ($tree, $vcs);
 }
 
@@ -1314,11 +1318,9 @@ END
 END
     } elsif ($vcs eq 'git') {
 
-	my $eff_tree = git_massage_url($tree);
-
         target_cmd_build($ho, $timeout, $builddir, <<END.
             $rm
-            git clone '$eff_tree' $subdir
+            git clone '$tree' $subdir
             cd $subdir
 END
                          (length($r{"revision_$which"}) ? <<END : ''));
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      parent reply	other threads:[~2016-07-12 17:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 17:40 [OSSTEST PATCH 0/4] Use cached git url for trees cloned by xen.git Ian Jackson
2016-07-12 17:40 ` [OSSTEST PATCH 1/4] Osstest/PDU/eth008: print actual error on failure Ian Jackson
2016-07-12 17:40 ` [OSSTEST PATCH 2/4] TestSupport: Break out build_url_vcs Ian Jackson
2016-07-12 17:40 ` [OSSTEST PATCH 3/4] ts-xen-build: Factor out config_tree Ian Jackson
2016-07-12 17:40 ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468345223-6457-5-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).