xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 4/5] ms-flights-summary: Treat preparing jobs outside the plan as `queued'
Date: Mon, 18 Jul 2016 15:04:05 +0100	[thread overview]
Message-ID: <1468850646-2283-4-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1468850646-2283-1-git-send-email-ian.jackson@eu.citrix.com>

These jobs are still to run but we have no time estimate for them.

So do not add them to UnqueuedJobs; they then contribute to making the
`End of phase/flight' indication *not* bold when there are such jobs.

And bolden their figure in the table.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 ms-flights-summary | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ms-flights-summary b/ms-flights-summary
index 9a814ea..e4ce03b 100755
--- a/ms-flights-summary
+++ b/ms-flights-summary
@@ -132,7 +132,9 @@ END
     }
 
     $f->{NrJobs} = keys %{$f->{Jobs}};
-    $f->{UnqueuedJobs} = $f->{NrJobs} - ($f->{Stats}{queued}//0);
+    $f->{UnqueuedJobs} = $f->{NrJobs}
+        - ($f->{Stats}{queued}//0)
+        - ($f->{Stats}{preparing}//0);
 }
 
 sub sort_stats($) {
@@ -407,7 +409,8 @@ foreach my $f (sort keys %flights) {
     print "  <td align=right><strong>$fi->{NrJobs}</strong></td>\n";
     foreach (@summarycounts) {
 	my $s = ($fi->{Stats}{$_} || '');
-	$s = "<strong>$s</strong>" if $s && $_ eq 'queued';
+	$s = "<strong>$s</strong>"
+            if $s && ($_ eq 'queued' || $_ eq 'preparing');
 	print "  <td align=right>$s</td>";
     }
     my $expectedend = fmttime($fi->{ExpectedEnd});
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-07-18 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 14:04 [OSSTEST PATCH 1/5] ms-flights-summary: Do gather_stats on jobs a bit later Ian Jackson
2016-07-18 14:04 ` [OSSTEST PATCH 2/5] ms-flights-summary: Do gather_stats without GROUP BY Ian Jackson
2016-07-18 14:04 ` [OSSTEST PATCH 3/5] ms-flights-summary: Invent a `prep.alloc.' pseudo job state Ian Jackson
2016-07-18 14:04 ` Ian Jackson [this message]
2016-07-18 14:04 ` [OSSTEST PATCH 5/5] sg-execute-flight: Fix an error message Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468850646-2283-4-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).