From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 03/11] xen: credit2: rework load tracking logic Date: Mon, 18 Jul 2016 16:51:37 +0200 Message-ID: <1468853497.13039.145.camel@citrix.com> References: <146859397891.10217.10155969474613302167.stgit@Solace.fritz.box> <146859416601.10217.14469582386972310679.stgit@Solace.fritz.box> <341508b6-7c22-fffa-97ff-6932b2a019e0@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7412810767535249222==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP9tZ-0004ED-S6 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2016 14:51:45 +0000 In-Reply-To: <341508b6-7c22-fffa-97ff-6932b2a019e0@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , xen-devel@lists.xenproject.org Cc: Anshul Makkar , David Vrabel List-Id: xen-devel@lists.xenproject.org --===============7412810767535249222== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-5evBpePDr78jczTBjDfL" --=-5evBpePDr78jczTBjDfL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2016-07-18 at 15:46 +0100, George Dunlap wrote: > On 15/07/16 15:49, Dario Faggioli wrote: > >=C2=A0 > > This may look handy, but it introduced a (not especially well > > documented) dependency between the lenght of the window and > > the precision of the calculations, which really should be > > two independent things. Especially if treating them as such > > (like it is done in this patch) does not lead to more > > complex maths (same number of multiplications and shifts, and > > there is still room for some optimization). > >=20 > > Therefore, in this patch, we: > > =C2=A0- split length of the window and precision (and, since there > > =C2=A0=C2=A0=C2=A0is already a command line parameter for length of win= dow, > > =C2=A0=C2=A0=C2=A0introduce one for precision too), > > =C2=A0- align the math with one proper incarnation of exponential > > =C2=A0=C2=A0=C2=A0smoothing (at no added cost), > > =C2=A0- add comments, about the details of the algorithm and the > > =C2=A0=C2=A0=C2=A0math used. > >=20 > > While there fix a couple of style issues as well (pointless > > initialization, long lines, comments). > >=20 > > Signed-off-by: Dario Faggioli > > --- > > Changes from v1: > > =C2=A0* reconciled comments and actual code about load_window_shift > > handling; > And this apparently means changing the code to match the comments > (not > the other way around), so that the actual load_window_shift default > is > now 30 (as the comments say) instead of 20 (as it was in the previous > patch). :-) >=20 Indeed. I should have made it more clear that this is what's happening... Sorry! :-) > Reviewed-by: George Dunlap >=20 Thanks, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-5evBpePDr78jczTBjDfL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXjOz6AAoJEBZCeImluHPuWaEQAKl42EY7t1awsW7P/HbZDWRY VWBlp0avnKwjzR3wTZWaABJuENgdSGDX2CCEfqK1SFBM/3UfXYX2eyD03jRJhP9z +J3JOqHFgijV2gtjL14/kzBUyOKhEoyh61wOr00BZKRs12ukWSt/YV0PJccAXzgL 37pfZtXMICMJbFrqTXCX9O/OpdNfviT7QS2j7s2dC6LtmArwRm6nan9ZfBGdvmol UcAIKUo9oUy5i5vCdTRDp9g0sjSC1luxky83oEWUD7TX2U4/VjOc/FcsY5MPfSBk pitn9VXKgxdlygKu72QeQ+8iKNOK15Q10ldCJWiGa0jjiTD1+fK4IKpJ1G0ESAXz SL+lCTWYHxmgVQ9LEUrSbNutegR/hPqWEhlZGSls8xrro4QQOTVwh5jfTcfuYY2J vk1Nn3dzERE64v4fh94BLjkM/+koGoDrZId/NdlgwRuR0TKuK3LpRxWaohOyZqj4 VnFZruCv6wotuq7wgCbxhBUGCzl0wWA/lZdSjB/zIHHA4OpmGV3SetQcdnJPb6eY EYJKa58bl1eBzFpApLK6bPG5VFrgHuakRJbdAX1OluEVa/66O3VSyF5vwFal8obJ drM2GP+L+Z90peDNV4CjLLzq3fHUdmaEUj3Cll8ViDnjvgJCQQKR5PVYUuIPlSpv mNZoKYvK1635SghMPVQh =4Qov -----END PGP SIGNATURE----- --=-5evBpePDr78jczTBjDfL-- --===============7412810767535249222== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7412810767535249222==--