From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 11/11] xen: credit2: implement true SMT support Date: Tue, 19 Jul 2016 11:57:41 +0200 Message-ID: <1468922261.13039.186.camel@citrix.com> References: <146859397891.10217.10155969474613302167.stgit@Solace.fritz.box> <146859422592.10217.3035174208345104624.stgit@Solace.fritz.box> <19d4fa2d-94ee-2fef-c106-06b8d7e72cfd@citrix.com> <1468862657.13039.164.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5974001035053171609==" Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPRme-00074V-0L for xen-devel@lists.xenproject.org; Tue, 19 Jul 2016 09:57:48 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: xen-devel , Anshul Makkar , David Vrabel , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============5974001035053171609== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-EHxzsrmB6Lhfix1kgsx3" --=-EHxzsrmB6Lhfix1kgsx3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-07-19 at 10:39 +0100, George Dunlap wrote: > On Mon, Jul 18, 2016 at 6:24 PM, Dario Faggioli > wrote: > >=C2=A0 > > If you're saying that this discrepancy between rqd->idle's and > > rqd->smt_idle's semantic is, at minimum, unideal, I do agree... but > > I > > think, for now at least, it's worth living with it. > I hadn't actually said anything, but you know me well enough to guess > what I'm thinking. :-)=C2=A0=C2=A0 > Hehe. :-) > I am somewhat torn between feeling like the > inconsistency and as you say, the fact that this is a distinct > improvement and it would seem a bit petty to insist that you either > wait or produce a patch to change idle at the same time. >=20 If we go ahead, I sign up for double checking and, if possible, fixing the inconsistency. > But I do think that the difference needs to be called out a bit > better.=C2=A0=C2=A0 > Yes, I was about to re-replying saying "perhaps we should add a comment about this". > What about folding in something like the attached patch? >=20 I'd be totally fine with this. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-EHxzsrmB6Lhfix1kgsx3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXjfmVAAoJEBZCeImluHPua/QP/2t2jKucIqxSXxRTcqVlGR85 hh2OuGSVj5sWBQobFZstqlpj+4qyv3gYgJKLkZPLYWRJNDIWhN5kbvbP0ChipNp5 729l7i3Ys+1F/IOiFcSNS6RaWL7oemUrZsCFKVOhjhYCtYlCdHc+R5dCQAWgEx6Z 6gz7gmIX4J9w3MgpqTUpaT8q170Q9qh2Mw6doFHJMd49w+wu9Vt1vO2Pbtt1WVou UC7hw2UJBh1YztA7Qb57YqFa6FT/ZYvGdJjlI4iy5zkpVPitp49pBUb42tX3L8LR aRMMktRs6mrR4BQTzd9n/7t9e73D3q9ZPGH2osS93kgULKsMaA5sjtNtPHrWvWXL B90gCM+iowCtqOZFO2LtcYTK0S5uKPCU7X5Doqny+lqyPcifcIwjoFyYGKV8P5JY dhz9D6JmeUIq9zcIfUWw1DG6vzcaJjQlN72uWyqQ2kN5IcBcmLQ8RMjgKbtABsqN bitxfIn9wszjMVI7pwmC5hK1XwiMKs7N5LDC2FgCLY/bd/6Tu961+bfxF+ngfjPG OMCcLJOE9Xg1jV81i2OAo9I3+JE5VT2GgQlrFuP4bpDuT6ke3QUcZe6emZ5qCC2h 6W2Gqwr+/VGqVlUg5+k/Jp/RJ+L21ERUgWMpMfmfqayn7z5vJSnXbLP4g47DS4HB j6H+amn+11i0oDSGXNju =FOlc -----END PGP SIGNATURE----- --=-EHxzsrmB6Lhfix1kgsx3-- --===============5974001035053171609== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5974001035053171609==--