From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Anshul Makkar <anshul.makkar@citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 1/2] xen: credit2: fix two s_time_t handling issues in load balancing
Date: Tue, 19 Jul 2016 15:39:34 +0200 [thread overview]
Message-ID: <1468935574.13039.195.camel@citrix.com> (raw)
In-Reply-To: <146893002307.30642.10136248649438820718.stgit@Solace.fritz.box>
[-- Attachment #1.1: Type: text/plain, Size: 887 bytes --]
On Tue, 2016-07-19 at 14:07 +0200, Dario Faggioli wrote:
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -656,7 +656,8 @@ __update_runq_load(const struct scheduler *ops,
> rqd->load += change;
> rqd->load_last_update = now;
>
> - ASSERT(rqd->avgload <= STIME_MAX && rqd->b_avgload <=
> STIME_MAX);
> + /* Overflow, capable of making the load look negative, must not
> occur. */
> + ASSERT(rqd->avgload > 0 && rqd->b_avgload > 0);
>
Wait! This quite obviously wants to be '>= 0' !!
Sorry for the glaring mistake. v2 coming...
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-19 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 12:06 [PATCH 0/2] xen: Credit2: fix two issues from recently committed series Dario Faggioli
2016-07-19 12:07 ` [PATCH 1/2] xen: credit2: fix two s_time_t handling issues in load balancing Dario Faggioli
2016-07-19 13:39 ` Dario Faggioli [this message]
2016-07-19 12:07 ` [PATCH 2/2] xen: credit2: fix potential issues in csched2_cpu_pick with tracing enabled Dario Faggioli
2016-07-19 12:20 ` [PATCH 0/2] xen: Credit2: fix two issues from recently committed series Andrew Cooper
2016-07-19 12:26 ` Dario Faggioli
2016-07-19 12:27 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468935574.13039.195.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anshul.makkar@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).