xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: xen-devel@lists.xen.org
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding
Date: Wed, 20 Jul 2016 15:49:44 +0100	[thread overview]
Message-ID: <1469026184-15320-2-git-send-email-ross.lagerwall@citrix.com> (raw)
In-Reply-To: <1469026184-15320-1-git-send-email-ross.lagerwall@citrix.com>

Don't change the timestamp of arch/x86/Makefile when editing it since it
forces much of the Xen tree to be rebuilt and then requires many
invocations of create-diff-tool.

This is safe since the Makefile change only changes the final link rule,
and xen will be relinked anyway.
---
 livepatch-build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/livepatch-build b/livepatch-build
index d9d9da3..c057fa1 100755
--- a/livepatch-build
+++ b/livepatch-build
@@ -98,10 +98,13 @@ function build_special()
     # Build with special GCC flags
     cd "${SRCDIR}/xen" || die
     sed -i 's/CFLAGS += -nostdinc/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/' Rules.mk
+    cp -p arch/x86/Makefile arch/x86/Makefile.bak
     sed -i 's/--section-alignment=0x200000/--section-alignment=0x1000/' arch/x86/Makefile
+    # Restore timestamps to prevent spurious rebuilding
+    touch --reference=arch/x86/Makefile.bak arch/x86/Makefile
     make "-j$CPUS" $XEN_DEBUG &> "${OUTPUT}/build_${name}_compile.log" || die
     sed -i 's/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/CFLAGS += -nostdinc/' Rules.mk
-    sed -i 's/--section-alignment=0x1000/--section-alignment=0x200000/' arch/x86/Makefile
+    mv -f arch/x86/Makefile.bak arch/x86/Makefile
 
     unset LIVEPATCH_BUILD_DIR
     unset LIVEPATCH_CAPTURE_DIR
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-07-20 14:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 14:49 [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Ross Lagerwall
2016-07-20 14:49 ` Ross Lagerwall [this message]
2016-07-21 14:33   ` [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding Konrad Rzeszutek Wilk
2016-07-21 14:48     ` Ross Lagerwall
2016-07-21 15:20       ` Konrad Rzeszutek Wilk
2016-07-21 14:33 ` [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469026184-15320-2-git-send-email-ross.lagerwall@citrix.com \
    --to=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).