From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Rusty Bird <rustybird@openmailbox.org>
Subject: [PATCH] systemd: remove hard-coded pid file in xendriverdomain service
Date: Wed, 20 Jul 2016 16:36:15 +0100 [thread overview]
Message-ID: <1469028975-16957-1-git-send-email-wei.liu2@citrix.com> (raw)
Per the discussion in [0], the hard-coded pid file can be removed
completely. Systemd has no trouble figuring out the pid of devd all by
itself.
[0]: https://lists.xen.org/archives/html/xen-devel/2016-07/msg01393.html
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Rusty Bird <rustybird@openmailbox.org>
---
tools/hotplug/Linux/systemd/xendriverdomain.service.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
index c0cd454..85972b5 100644
--- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
+++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
@@ -7,8 +7,7 @@ ConditionVirtualization=xen
[Service]
Type=forking
-ExecStart=@sbindir@/xl devd --pidfile=/var/run/xldevd.pid
-PIDFile=/var/run/xldevd.pid
+ExecStart=@sbindir@/xl devd
[Install]
WantedBy=multi-user.target
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-07-20 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 15:36 Wei Liu [this message]
2016-08-02 13:41 ` [PATCH] systemd: remove hard-coded pid file in xendriverdomain service Ian Jackson
2016-08-02 13:58 ` Wei Liu
2016-08-02 17:39 ` Rusty Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469028975-16957-1-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rustybird@openmailbox.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).