[PATCH] systemd: remove hard-coded pid file in xendriverdomain service

[PATCH] systemd: remove hard-coded pid file in xendriverdomain service

[Wei Liu]

Per the discussion in [0], the hard-coded pid file can be removed
completely. Systemd has no trouble figuring out the pid of devd all by
itself.

[0]: https://lists.xen.org/archives/html/xen-devel/2016-07/msg01393.html

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Rusty Bird <rustybird@openmailbox.org>
---
 tools/hotplug/Linux/systemd/xendriverdomain.service.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
index c0cd454..85972b5 100644
--- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
+++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
@@ -7,8 +7,7 @@ ConditionVirtualization=xen
 
 [Service]
 Type=forking
-ExecStart=@sbindir@/xl devd --pidfile=/var/run/xldevd.pid
-PIDFile=/var/run/xldevd.pid
+ExecStart=@sbindir@/xl devd
 
 [Install]
 WantedBy=multi-user.target
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] systemd: remove hard-coded pid file in xendriverdomain service

[Ian Jackson]

Wei Liu writes ("[PATCH] systemd: remove hard-coded pid file in xendriverdomain service"):
> Per the discussion in [0], the hard-coded pid file can be removed
> completely. Systemd has no trouble figuring out the pid of devd all by
> itself.
> 
> [0]: https://lists.xen.org/archives/html/xen-devel/2016-07/msg01393.html

I'm not qualified to have much of an opinion this but I'm happy to see
it go in based on what I assume is a test report from Rusty Bird ?

On that basis,

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] systemd: remove hard-coded pid file in xendriverdomain service

[Wei Liu]

On Tue, Aug 02, 2016 at 02:41:58PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH] systemd: remove hard-coded pid file in xendriverdomain service"):
> > Per the discussion in [0], the hard-coded pid file can be removed
> > completely. Systemd has no trouble figuring out the pid of devd all by
> > itself.
> > 
> > [0]: https://lists.xen.org/archives/html/xen-devel/2016-07/msg01393.html
> 
> I'm not qualified to have much of an opinion this but I'm happy to see
> it go in based on what I assume is a test report from Rusty Bird ?
> 

No, it's not a test report.

Rusty Bird was the submitter of that xl devd unit file. I assumed he had
experience of setting up xl devd without a pid file under systemd  and
did what he asked for.

> On that basis,
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] systemd: remove hard-coded pid file in xendriverdomain service

[Rusty Bird]

[-- Attachment #1.1.1: Type: text/plain, Size: 861 bytes --]

Wei Liu:
> On Tue, Aug 02, 2016 at 02:41:58PM +0100, Ian Jackson wrote:
>> Wei Liu writes ("[PATCH] systemd: remove hard-coded pid file in xendriverdomain service"):
>>> Per the discussion in [0], the hard-coded pid file can be removed
>>> completely. Systemd has no trouble figuring out the pid of devd all by
>>> itself.
>>>
>>> [0]: https://lists.xen.org/archives/html/xen-devel/2016-07/msg01393.html
>>
>> I'm not qualified to have much of an opinion this but I'm happy to see
>> it go in based on what I assume is a test report from Rusty Bird ?
>>
> 
> No, it's not a test report.
> 
> Rusty Bird was the submitter of that xl devd unit file. I assumed he had
> experience of setting up xl devd without a pid file under systemd  and
> did what he asked for.

Yes, I tried it without a PID file and did not notice any issues.

Rusty


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 931 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel