xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
	osstest service owner <osstest-admin@xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	xen-devel@lists.xensource.com
Subject: Re: [xen-unstable test] 97737: regressions - FAIL
Date: Fri, 22 Jul 2016 14:10:03 +0200	[thread overview]
Message-ID: <1469189403.13039.296.camel@citrix.com> (raw)
In-Reply-To: <20160722104930.GA17004@citrix.com>


[-- Attachment #1.1: Type: text/plain, Size: 1717 bytes --]

On Fri, 2016-07-22 at 11:49 +0100, Wei Liu wrote:
> On Fri, Jul 22, 2016 at 03:27:30AM +0000, osstest service owner
> wrote:
> > 
> > flight 97737 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/97737/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  test-amd64-amd64-xl-credit2  19 guest-start/debian.repeat fail
> > REGR. vs. 97664
> >  test-armhf-armhf-xl          15 guest-start/debian.repeat fail
> > REGR. vs. 97664
> >  test-armhf-armhf-xl-credit2  15 guest-start/debian.repeat fail
> > REGR. vs. 97664
>
Thanks from bringing my attention to this. I've seen it happening in
local testing a few times also, and was investigating already.

> From
> http://logs.test-lab.xenproject.org/osstest/logs/97737/test-amd64-amd
> 64-xl-credit2/serial-fiano0.log
> 
> Jul 21 07:38:22.383917 (XEN) Assertion 'rqd->avgload >= 0 && rqd-
> >b_avgload >= 0' failed at sched_credit2.c:734
>
Right. My investigation shows that it is the b_avgload>=0 check that is
actually failing, and looking at the code confirmed that, and I found
out why.

I've just sent a patch that I believe will fix this.

I can't find it in the archives yet, but it should be:
 [PATCH] xen: credit2: don't let b_avgload go negative.
 msg-id: <146918909364.19443.6394900696027710502.stgit@Solace.fritz.box>

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-07-22 12:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22  3:27 [xen-unstable test] 97737: regressions - FAIL osstest service owner
2016-07-22 10:49 ` Wei Liu
2016-07-22 12:10   ` Dario Faggioli [this message]
2016-07-25  8:53 ` Wei Liu
2016-07-25 11:05   ` Julien Grall
2016-07-25 11:11     ` Wei Liu
2016-07-25 11:34       ` Julien Grall
2016-07-25 11:53         ` Wei Liu
2016-07-26  9:52           ` Julien Grall
2016-07-26 10:05             ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469189403.13039.296.camel@citrix.com \
    --to=dario.faggioli@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=osstest-admin@xenproject.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).