From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: [OSSTEST PATCH 3/3] cr-ensure-disk-space: Correct stdout output
Date: Mon, 25 Jul 2016 11:34:43 +0100 [thread overview]
Message-ID: <1469442883-26212-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1469442883-26212-1-git-send-email-ian.jackson@eu.citrix.com>
d221996eea64 "cr-ensure-disk-space: Run check_space before taking
lock" introduced an additional call to check_space but check_space
prints the start of a message (with no newline) expecting
iteration_proceed to print the rest.
Move $|=1 up appropriately and add a couple of messages in the right
place. This involves calling quit_ok rather than exit 0.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
cr-ensure-disk-space | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cr-ensure-disk-space b/cr-ensure-disk-space
index 6a9781a..ff6b01b 100755
--- a/cr-ensure-disk-space
+++ b/cr-ensure-disk-space
@@ -68,13 +68,15 @@ sub quit_ok () {
$|=1;
-exit 0 if check_space;
+check_space if check_space;
+
+print "taking lock...";
my $lock = "$c{GlobalLockDir}/publish-lock";
open LOCK, "> $lock" or die "$lock $!";
flock LOCK, LOCK_EX or die $!;
-$|=1;
+print "proceeding...\n";
my $chkq= db_prepare("SELECT * FROM flights WHERE flight=?");
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-07-25 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 10:34 [OSSTEST PATCH 1/3] cr-ensure-disk-space: Fix reference to iteration_proceed Ian Jackson
2016-07-25 10:34 ` [OSSTEST PATCH 2/3] cr-ensure-disk-space: Break out quit_ok Ian Jackson
2016-07-25 10:34 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469442883-26212-3-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).