Re: [PATCH v2] libxl: memory size in kb requires 64 bit variable

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]

On Thu, 2016-07-28 at 14:48 +0200, Juergen Gross wrote:
> On 28/07/16 14:11, Dario Faggioli wrote:
> >  
> > > +static int libxl__memkb_32to64(libxl_ctx *ctx, int rc,
> > > +                               uint64_t val64, uint32_t *ptr32)
> > > +{
> > > +    GC_INIT(ctx);
> > > +
> > > +    if (rc)
> > > +        goto out;
> > > +
> > > +    *ptr32 = val64;
> > > +    if (*ptr32 == val64)
> > > +        goto out;
> > > +
> > > +    LOGE(ERROR, "memory size %"PRIu64" too large for 32 bit
> > > value\n", val64);
> > > +    rc = ERROR_FAIL;
> > > +
> > > +out:
> > > +    GC_FREE;
> > > +    return rc;
> > > +}
> > > +
> > ...does more 64to32 then 32to64, but maybe that's me, and, anyway,
> > it's
> > certainly not a big deal.
> Hmm, yes, I can see your point.
> 
> Will do V3. Only doing the rename, can I keep your Reviewed-by: ?
> 
Yes, you can.

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel