From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] libxl: memory size in kb requires 64 bit variable Date: Thu, 28 Jul 2016 15:21:58 +0200 Message-ID: <1469712118.5501.5.camel@citrix.com> References: <1469170393-9487-1-git-send-email-jgross@suse.com> <1469707903.5501.3.camel@citrix.com> <4e4e22f7-c33e-f996-bf6c-e6b0658989a4@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5288562645254341640==" Return-path: In-Reply-To: <4e4e22f7-c33e-f996-bf6c-e6b0658989a4@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============5288562645254341640== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-HRSk6ZOfzo9bNCxIk20A" --=-HRSk6ZOfzo9bNCxIk20A Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-07-28 at 14:48 +0200, Juergen Gross wrote: > On 28/07/16 14:11, Dario Faggioli wrote: > > =C2=A0 > > > +static int libxl__memkb_32to64(libxl_ctx *ctx, int rc, > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint64_t val64, uint32_t *ptr3= 2) > > > +{ > > > +=C2=A0=C2=A0=C2=A0=C2=A0GC_INIT(ctx); > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0if (rc) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0goto out; > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0*ptr32 =3D val64; > > > +=C2=A0=C2=A0=C2=A0=C2=A0if (*ptr32 =3D=3D val64) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0goto out; > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0LOGE(ERROR, "memory size %"PRIu64" too large= for 32 bit > > > value\n", val64); > > > +=C2=A0=C2=A0=C2=A0=C2=A0rc =3D ERROR_FAIL; > > > + > > > +out: > > > +=C2=A0=C2=A0=C2=A0=C2=A0GC_FREE; > > > +=C2=A0=C2=A0=C2=A0=C2=A0return rc; > > > +} > > > + > > ...does more 64to32 then 32to64, but maybe that's me, and, anyway, > > it's > > certainly not a big deal. > Hmm, yes, I can see your point. >=20 > Will do V3. Only doing the rename, can I keep your Reviewed-by: ? >=20 Yes, you can. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-HRSk6ZOfzo9bNCxIk20A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXmgb2AAoJEBZCeImluHPut8sQAK6OuWbf0pSi/v/k5Mtyhfzn nYdrxrQeqF8Z2M/lEsakMYkcmGCZBbj9Ki58GgzExyk3VfFCqrDWRHGAjOMn9Qo8 mFWUz3xVGlLsJ53TuqRWxCuHSkYR0zKIEZFdP9OJk6k/FG6aiRAKkC4HcjEQoB2r QLq8MOLk2b6SuACfJuFNPRvVlpyuXkbWPL168sFdJv4vPWw4WP8ZZ91JJJUsmwyb xW5T6tsSN5tmuN7/KosRyNdnkfcR4IO/n9dkp+rNl00Ezj3Lajge7T31KThq1FWW Ou8/xSggPg5V0+y21gLeFDAfp0YpwrFN1oasseiKseLIfi4Fbku5UAG6b2jGEHwb sck+qFdAo5FrvMA1on4aVB9lyW7FAhQ5LwLuwdZvbJSYSEAFM2kDAjPZnIcSczk+ sSqhMZNq3QaYZRlrpA2KJBYLisoLZJ6gqOaZvfUWgDe5qR1dKCBTK9r6Bkfoowpu SBqKCVSccRQQ0B6XjG01R3WQh5+lSplWslgaM5BHqUJvYws9caX/9ctfK8AdvQFV lvKCyBqZ4W3t6iFGlCLpvPG84Oe2s+ySlxxyMnmEiDvY3MTnQmYpxO/+AhynrxhR y/y4Br2qZ/MtPSUvPgNLsYE4j5GewCCLCD2dEsOhl+UNO+ADwVsLqxgngcNBsvUn MtlFDv8FubguzPcj9iLS =T3pu -----END PGP SIGNATURE----- --=-HRSk6ZOfzo9bNCxIk20A-- --===============5288562645254341640== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5288562645254341640==--