* [PATCH] docs: define semantics of vncpasswd in xl.cfg
@ 2016-07-29 22:56 Jim Fehlig
2016-08-01 9:44 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Jim Fehlig @ 2016-07-29 22:56 UTC (permalink / raw)
To: xen-devel; +Cc: wei.liu2, Jim Fehlig, ian.jackson
A recent discussion around LSN-2016-0001 [1] included defining
the sematics of an empty string for a VNC password. It was stated
that "libxl interprets an empty password in the caller's
configuration to mean that passwordless access should be permitted".
The same applies for vncpasswd setting in xl.cfg. This patch
extends to xl.cfg documentation to define the semantics of setting
vncpasswd to an empty string.
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
docs/man/xl.cfg.pod.5.in | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
index 3bb27d0..48c9c0d 100644
--- a/docs/man/xl.cfg.pod.5.in
+++ b/docs/man/xl.cfg.pod.5.in
@@ -561,7 +561,9 @@ The actual display used can be accessed with C<xl vncviewer>.
=item C<vncpasswd="PASSWORD">
-Specifies the password for the VNC server.
+Specifies the password for the VNC server. If password is set to an
+empty string, authentication on the VNC server will be disabled
+allowing any user to connect.
=item C<sdl=BOOLEAN>
@@ -1689,7 +1691,9 @@ The actual display used can be accessed with C<xl vncviewer>.
=item B<vncpasswd="PASSWORD">
-Specifies the password for the VNC server.
+Specifies the password for the VNC server. If password is set to an
+empty string, authentication on the VNC server will be disabled
+allowing any user to connect.
=item B<keymap="LANG">
--
1.8.0.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: define semantics of vncpasswd in xl.cfg
2016-07-29 22:56 [PATCH] docs: define semantics of vncpasswd in xl.cfg Jim Fehlig
@ 2016-08-01 9:44 ` Ian Jackson
2016-08-02 16:04 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2016-08-01 9:44 UTC (permalink / raw)
To: Jim Fehlig; +Cc: wei.liu2, xen-devel
Jim Fehlig writes ("[PATCH] docs: define semantics of vncpasswd in xl.cfg"):
> A recent discussion around LSN-2016-0001 [1] included defining
> the sematics of an empty string for a VNC password. It was stated
> that "libxl interprets an empty password in the caller's
> configuration to mean that passwordless access should be permitted".
>
> The same applies for vncpasswd setting in xl.cfg. This patch
> extends to xl.cfg documentation to define the semantics of setting
> vncpasswd to an empty string.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
I think this is a backport candidate.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: define semantics of vncpasswd in xl.cfg
2016-08-01 9:44 ` Ian Jackson
@ 2016-08-02 16:04 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-08-02 16:04 UTC (permalink / raw)
To: Ian Jackson; +Cc: Jim Fehlig, wei.liu2, xen-devel
On Mon, Aug 01, 2016 at 10:44:45AM +0100, Ian Jackson wrote:
> Jim Fehlig writes ("[PATCH] docs: define semantics of vncpasswd in xl.cfg"):
> > A recent discussion around LSN-2016-0001 [1] included defining
> > the sematics of an empty string for a VNC password. It was stated
> > that "libxl interprets an empty password in the caller's
> > configuration to mean that passwordless access should be permitted".
> >
> > The same applies for vncpasswd setting in xl.cfg. This patch
> > extends to xl.cfg documentation to define the semantics of setting
> > vncpasswd to an empty string.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> I think this is a backport candidate.
>
Acked + pushed.
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-02 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-29 22:56 [PATCH] docs: define semantics of vncpasswd in xl.cfg Jim Fehlig
2016-08-01 9:44 ` Ian Jackson
2016-08-02 16:04 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).