xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>
Subject: [OSSTEST PATCH RFC v2 05/14] BuildSupport: move buildcmd_stamped_logged here
Date: Mon, 8 Aug 2016 10:22:37 +0100	[thread overview]
Message-ID: <1470648166-3412-6-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1470648166-3412-1-git-send-email-wei.liu2@citrix.com>

... so that other build scripts can use it, too.

It now accepts one more parameter called "component" to be useful in
other build scripts.

No functional change.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
v2: new
---
 Osstest/BuildSupport.pm | 15 +++++++++++++++
 ts-xen-build            | 18 ++----------------
 2 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/Osstest/BuildSupport.pm b/Osstest/BuildSupport.pm
index a183546..dfdf2e4 100644
--- a/Osstest/BuildSupport.pm
+++ b/Osstest/BuildSupport.pm
@@ -36,6 +36,7 @@ BEGIN {
                       $whhost $ho
 
                       builddirsprops
+                      buildcmd_stamped_logged
                       $builddir $makeflags
 
                       prepbuilddirs
@@ -56,6 +57,20 @@ our ($whhost,$ho);
 our ($builddir,$makeflags);
 our ($xendist);
 
+sub buildcmd_stamped_logged ($$$$$$) {
+    my ($timeout, $component, $stampname, $prefix, $cmd, $suffix) = @_;
+    target_cmd_build($ho, $timeout, $builddir, <<END);
+        cd $component
+        $prefix
+        ( $cmd 2>&1 &&             touch ../$stampname-ok-stamp
+        ) |tee ../$stampname-log
+        test -f ../$stampname-ok-stamp
+        $suffix
+        echo ok.
+END
+#/;
+}
+
 sub selectbuildhost {
     # pass \@ARGV
     my ($av) = @_;
diff --git a/ts-xen-build b/ts-xen-build
index 58670f1..5e076d7 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -95,20 +95,6 @@ END
                );
 }
 
-sub buildcmd_stamped_logged ($$$$$) {
-    my ($timeout, $stampname, $prefix, $cmd, $suffix) = @_;
-    target_cmd_build($ho, $timeout, $builddir, <<END);
-        cd xen
-        $prefix
-        ( $cmd 2>&1 &&             touch ../$stampname-ok-stamp
-        ) |tee ../$stampname-log
-        test -f ../$stampname-ok-stamp
-        $suffix
-        echo ok.
-END
-#/;
-}
-
 sub build () {
     my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
     my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";
@@ -116,7 +102,7 @@ sub build () {
     my $configure_prefix = $r{cmdprefix_configure} // '';
     my $make_prefix =      $r{cmdprefix_make}      // '';
 
-    buildcmd_stamped_logged(600, 'configure', <<END,<<END,<<END);
+    buildcmd_stamped_logged(600, 'xen', 'configure', <<END,<<END,<<END);
             if test -f configure; then
                 if grep -q -- $xend_opt tools/configure ; then
 		    xend=$xend_opt
@@ -130,7 +116,7 @@ END
             fi
 END
 #/;
-    buildcmd_stamped_logged(9000, 'build', '',<<END,'');
+    buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
             if test -f xen/Kconfig; then
                 $make_prefix make -C xen olddefconfig
             fi
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-08-08  9:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08  9:22 [OSSTEST PATCH RFC v2 00/14] Integrate XTF into OSSTest Wei Liu
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 01/14] ts-xen-build: always compile in FEP support Wei Liu
2016-08-08 14:46   ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 02/14] DO NOT APPLY ts-leak-check: sleep 5 seconds before collecting stuff Wei Liu
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 03/14] ap-common: add xtf tree Wei Liu
2016-08-08 14:46   ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 04/14] DO NOT APPLY point xtf to my personal tree Wei Liu
2016-08-08  9:22 ` Wei Liu [this message]
2016-08-08 14:47   ` [OSSTEST PATCH RFC v2 05/14] BuildSupport: move buildcmd_stamped_logged here Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 06/14] Introduce ts-xtf-build Wei Liu
2016-08-08 14:48   ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 07/14] sg-run-job: create xtf build recipe Wei Liu
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 08/14] Introduce ts-xtf-install Wei Liu
2016-08-08 14:49   ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 09/14] mfi-common: create xtf build job for 4.8 onwards Wei Liu
2016-08-08 14:51   ` Ian Jackson
2016-08-08 16:21     ` Wei Liu
2016-08-08 16:26       ` Andrew Cooper
2016-08-08 16:58         ` Wei Liu
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 10/14] Introduce ts-xtf-fep Wei Liu
2016-08-08 14:52   ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 11/14] Introduce ts-xtf-run Wei Liu
2016-08-08 14:55   ` Ian Jackson
2016-08-09  8:11     ` Wei Liu
2016-08-08 16:29   ` Andrew Cooper
2016-08-08 16:56     ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 12/14] sg-run-job: test-xtf recipe Wei Liu
2016-08-08 14:56   ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 13/14] make-flight: create 5 xtf jobs Wei Liu
2016-08-08 14:56   ` Ian Jackson
2016-08-08  9:22 ` [OSSTEST PATCH RFC v2 14/14] Create XTF branch Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470648166-3412-6-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).