From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: xen-devel@lists.xen.org
Cc: andrew.cooper3@citrix.com, boris.ostrovsky@oracle.com,
ian.jackson@eu.citrix.com, wei.liu2@citrix.com,
jbeulich@suse.com
Subject: [PATCH 2/2] hvmloader: acpi_build_tables() can't take acpi_config as const
Date: Tue, 9 Aug 2016 18:06:02 -0400 [thread overview]
Message-ID: <1470780363-14549-3-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1470780363-14549-1-git-send-email-boris.ostrovsky@oracle.com>
We'd need to update other routines' definitions. However, acpi_config
is not really a const since new_vm_gid() wants to update
acpi_config.vm_gid_addr.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
tools/firmware/hvmloader/acpi/build.c | 2 +-
tools/firmware/hvmloader/acpi/libacpi.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/firmware/hvmloader/acpi/build.c b/tools/firmware/hvmloader/acpi/build.c
index 360dd1c..dccddff 100644
--- a/tools/firmware/hvmloader/acpi/build.c
+++ b/tools/firmware/hvmloader/acpi/build.c
@@ -474,7 +474,7 @@ static int new_vm_gid(struct acpi_config *config,
return 1;
}
-void acpi_build_tables(const struct acpi_config *config)
+void acpi_build_tables(struct acpi_config *config)
{
struct acpi_info *acpi_info;
struct acpi_20_rsdp *rsdp;
diff --git a/tools/firmware/hvmloader/acpi/libacpi.h b/tools/firmware/hvmloader/acpi/libacpi.h
index de4470a..22fd5f6 100644
--- a/tools/firmware/hvmloader/acpi/libacpi.h
+++ b/tools/firmware/hvmloader/acpi/libacpi.h
@@ -60,7 +60,7 @@ struct acpi_config {
unsigned int rsdp;
};
-void acpi_build_tables(const struct acpi_config *config);
+void acpi_build_tables(struct acpi_config *config);
#endif /* __LIBACPI_H__ */
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-09 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 22:06 [PATCH 0/2] hvmloader regression fixes Boris Ostrovsky
2016-08-09 22:06 ` [PATCH 1/2] hvmloader: Include libacpi.h instead of acpi2_0.h Boris Ostrovsky
2016-08-09 22:06 ` Boris Ostrovsky [this message]
2016-08-09 22:06 ` [PATCH-alt 2/2] hvmloader: Make acpi_build_tables() return vm_gid_addr outside struct acpi_config Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470780363-14549-3-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).