From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: [OSSTEST PATCH 5/7] sg-report-flight: Fix misleading value in call to duration_estimator
Date: Thu, 11 Aug 2016 17:18:01 +0100 [thread overview]
Message-ID: <1470932283-17445-6-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1470932283-17445-1-git-send-email-ian.jackson@eu.citrix.com>
The third argument is $debug. If it's falseish, a default subref is
used instead. Passing '' is confusing; pass undef instead.
No functional change.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
sg-report-flight | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sg-report-flight b/sg-report-flight
index de1fd14..47ecf07 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -763,7 +763,7 @@ END
my $duration_estimator= duration_estimator($branch, $blessings[0]);
foreach my $failv (@failures) {
- my ($est) = $duration_estimator->($failv->{Job}{job},'','');
+ my ($est) = $duration_estimator->($failv->{Job}{job},'',undef);
if (!defined $est) { $est = 1e5; }
print DEBUG "DE $failv->{Job}{job} $est\n";
$failv->{DurationEstimate}= $est;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-11 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 16:17 [OSSTEST PATCH 0/7] Apropos of XTF: Improve failed step selection Ian Jackson
2016-08-11 16:17 ` [OSSTEST PATCH 1/7] duration_estimator: Introduce $duration_duration_qtxt and @d_d_args Ian Jackson
2016-08-11 16:17 ` [OSSTEST PATCH 2/7] duration_estimator: Reformat inner SQL query with more newlines Ian Jackson
2016-08-11 16:17 ` [OSSTEST PATCH 3/7] duration_estimator: Reorganise inner SQL query to use WITH Ian Jackson
2016-08-11 16:18 ` [OSSTEST PATCH 4/7] duration_estimator: Be able to estimate job duration up to a particular step Ian Jackson
2016-08-11 16:18 ` Ian Jackson [this message]
2016-08-11 16:18 ` [OSSTEST PATCH 6/7] sg-report-flight: Fix a missing newline in a DEBUG message Ian Jackson
2016-08-11 16:18 ` [OSSTEST PATCH 7/7] sg-report-flight: Report earlier, earlier step failures Ian Jackson
2016-08-11 17:05 ` [OSSTEST PATCH 0/7] Apropos of XTF: Improve failed step selection Wei Liu
2016-08-30 16:00 ` Wei Liu
2016-08-30 16:08 ` Ian Jackson
2016-08-30 16:13 ` Andrew Cooper
2016-09-05 18:08 ` Wei Liu
2016-09-06 9:45 ` Ian Jackson
2016-09-06 9:46 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470932283-17445-6-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).