From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen: credit1: fix a race when picking initial pCPU for a vCPU Date: Fri, 12 Aug 2016 11:46:39 +0200 Message-ID: <1470995199.6250.89.camel@citrix.com> References: <147097482567.29177.2373077001942557324.stgit@Solace.fritz.box> <9ae42c19-8326-f13c-4c9c-83641c93efcd@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5155114072985271342==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bY93c-0004Vp-PI for xen-devel@lists.xenproject.org; Fri, 12 Aug 2016 09:47:16 +0000 In-Reply-To: <9ae42c19-8326-f13c-4c9c-83641c93efcd@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , xen-devel@lists.xenproject.org Cc: George Dunlap , Andrew Cooper , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============5155114072985271342== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Z6NhqfwcExMU16n3IH8g" --=-Z6NhqfwcExMU16n3IH8g Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-08-12 at 10:14 +0100, George Dunlap wrote: > On 12/08/16 05:07, Dario Faggioli wrote: > >=C2=A0 > > Reported-by: Andrew Cooper > > Signed-off-by: Dario Faggioli > It might be nice if we could add an ASSERT() that the appropriate > runqueue was locked, to make sure we don't get caught out again like > this in the future, but I think that would probably require turning > it > into a static inline (which probably wouldn't be so bad anyway). >=20 Mmm... good point. > But in any case: >=20 > Acked-by: George Dunlap >=20 > Let me know if you want me to check this in as-is or if you think you > might send a follow-up patch adding an ASSERT. >=20 Yes, I'll send a new patch. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Z6NhqfwcExMU16n3IH8g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXrZr/AAoJEBZCeImluHPuIiUQAMgUtPULumGhHDzqW/NZtMh+ eTiu4eovn5oMPPlGKznw/pAlcXgGbzaNJbSo9eDCCg3u3tdUY+BsnIFoSf4dtP1E 98n46HVyzoxB4219AaU3wJRGH9OrjvzH+ePst5PR4KaI/9W2d68AAP3dVuVFM7gr iiQ906P7fvVMDKxz764alJgVvlbUFGzHfWrfC+WfhQ5n8d86m1e9UKiEeMzVLdiD Cb7aexlS33fNdjvFFpYr7bl9S1tZ2IhMaN3OWQ70AFCM0IYePzymTkTdcGYCwVfA gOGTkgJgpn8sPPgoH4BTCuetJdw+KK2aFuweRAcdBKM4KZezwJnpc3d/FdwwWu+Z CJilt/0UIUIXbBm06aAosQ2yTCNJCjGA620Xh3wJ0w8NaRIzWv5KIjXGbtm0q1nm UETnxlFg+F/L44hfBysCvONllW20JMcnh/Av4xndf4kLU6/sT3uOiaySMendV//m UqS02Cq1Cac51L//C05vOXB2Q4CuLNZ16g9f00uTpveuwFSy4+IvhPEEgk6GY7aw dB8m5n8r9eygb1J12K6SYDy/ehBAd7evkMeminlUf4ZT7nNlFAvNE8Eo5jSztsVk BXqofz++KcVPD26sibcOqeuwzpf+eUETUcOslRTyfIwR7CQws23lQyhd4tgAczzD TrdDc1LJWFtdmOFR2VPX =cthN -----END PGP SIGNATURE----- --=-Z6NhqfwcExMU16n3IH8g-- --===============5155114072985271342== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5155114072985271342==--