From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xenproject.org, konrad@kernel.org,
ross.lagerwall@citrix.com
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v3 2/9] livepatch: Deal with payloads without any .text
Date: Sun, 14 Aug 2016 17:52:19 -0400 [thread overview]
Message-ID: <1471211546-2235-3-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1471211546-2235-1-git-send-email-konrad.wilk@oracle.com>
It is possible. Especially if the only thing they do is
NOP functions - in which case there is only .livepatch.funcs
sections.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
v3: First submission.
---
xen/common/livepatch.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index 47a23cf..17427b1 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -399,16 +399,17 @@ static int move_payload(struct payload *payload, struct livepatch_elf *elf)
static int secure_payload(struct payload *payload, struct livepatch_elf *elf)
{
- int rc;
+ int rc = 0;
unsigned int text_pages, rw_pages, ro_pages;
text_pages = PFN_UP(payload->text_size);
- ASSERT(text_pages);
-
- rc = arch_livepatch_secure(payload->text_addr, text_pages, LIVEPATCH_VA_RX);
- if ( rc )
- return rc;
+ if ( text_pages )
+ {
+ rc = arch_livepatch_secure(payload->text_addr, text_pages, LIVEPATCH_VA_RX);
+ if ( rc )
+ return rc;
+ }
rw_pages = PFN_UP(payload->rw_size);
if ( rw_pages )
{
--
2.4.11
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-14 21:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-14 21:52 [PATCH v3] Livepatch fixes and features for v4.8 Konrad Rzeszutek Wilk
2016-08-14 21:52 ` [PATCH v3 1/9] livepatch: Clear .bss when payload is reverted Konrad Rzeszutek Wilk
2016-08-15 10:27 ` Jan Beulich
2016-08-15 14:29 ` Konrad Rzeszutek Wilk
2016-08-15 15:10 ` Jan Beulich
2016-08-19 8:37 ` Ross Lagerwall
2016-08-19 8:42 ` Jan Beulich
2016-08-14 21:52 ` Konrad Rzeszutek Wilk [this message]
2016-08-15 10:28 ` [PATCH v3 2/9] livepatch: Deal with payloads without any .text Jan Beulich
2016-08-19 9:31 ` Ross Lagerwall
2016-08-14 21:52 ` [PATCH v3 3/9] version/livepatch: Move xen_build_id_check to version.h Konrad Rzeszutek Wilk
2016-08-15 10:35 ` Jan Beulich
2016-08-19 9:29 ` Ross Lagerwall
2016-08-14 21:52 ` [PATCH v3 4/9] livepatch: Sync cache of build-id before using it first time Konrad Rzeszutek Wilk
2016-08-15 10:38 ` Jan Beulich
2016-08-15 10:46 ` Andrew Cooper
2016-08-15 14:33 ` Konrad Rzeszutek Wilk
2016-08-14 21:52 ` [PATCH v3 5/9] livepatch: Move code from prepare_payload to own routine Konrad Rzeszutek Wilk
2016-08-15 10:41 ` Jan Beulich
2016-08-19 9:37 ` Ross Lagerwall
2016-08-14 21:52 ` [PATCH v3 6/9] livepatch: Add parsing for the symbol+0x<offset>/<len> Konrad Rzeszutek Wilk
2016-08-15 10:53 ` Jan Beulich
2016-08-15 14:35 ` Konrad Rzeszutek Wilk
2016-08-15 15:12 ` Jan Beulich
2016-08-15 15:21 ` Konrad Rzeszutek Wilk
2016-08-14 21:52 ` [PATCH v3 7/9] livepatch: NOP if func->new_[addr, size] is zero Konrad Rzeszutek Wilk
2016-08-15 10:59 ` Jan Beulich
2016-08-15 14:38 ` Konrad Rzeszutek Wilk
2016-08-14 21:52 ` [PATCH v3 8/9] symbols: Generate an xen-sym.map Konrad Rzeszutek Wilk
2016-08-15 11:02 ` Jan Beulich
2016-08-14 21:52 ` [PATCH v3 9/9] livepach: Add .livepatch.hooks functions and test-case Konrad Rzeszutek Wilk
2016-08-15 11:15 ` Jan Beulich
2016-08-15 14:46 ` Konrad Rzeszutek Wilk
2016-08-15 15:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471211546-2235-3-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad@kernel.org \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).