From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 2/2] x86/NUMA: cleanup Date: Tue, 16 Aug 2016 12:02:14 +0200 Message-ID: <1471341734.6806.7.camel@citrix.com> References: <57AB0D5C020000780010493B@prv-mh.provo.novell.com> <57AB0ED10200007800104953@prv-mh.provo.novell.com> <07946053-b703-f19b-4676-70001ac6cc3a@citrix.com> <57AB306A0200007800104A8E@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7366772114465627862==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZbCz-0008Vs-0o for xen-devel@lists.xenproject.org; Tue, 16 Aug 2016 10:02:57 +0000 In-Reply-To: <57AB306A0200007800104A8E@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Andrew Cooper , xen-devel Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org --===============7366772114465627862== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-T37PYx4Dr4+mWTWfVlcl" --=-T37PYx4Dr4+mWTWfVlcl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-08-10 at 05:47 -0600, Jan Beulich wrote: > > On 10.08.16 at 12:35, wrote: > > I observe that CONFIG_NUMA_EMU is also unconditionally true, which > > offers further cleanup opportunities (albeit it probably a separate > > patch). > So I thought, but then wasn't sure eliminating just the conditionals > it would actually be the right route - the alternative would be to > instead just drop that NUMA emulation code altogether, as no-one > should be using it. >=20 Last time I tried to use it, it indeed was *not* useful at all... and looking at it, it seems that nothing changed since then. AFAICT, it's something imported from Linux quite a few time back, but while Linux evolved its own NUMA_EMU support to something that may actually be useful, ours stayed original. So, for what the opinion of someone that tried to use it is worth, I agree that we either also improve it (e.g., by trying syncing with the Linux one), or kill it. Regards, Dairo --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-T37PYx4Dr4+mWTWfVlcl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXsuSuAAoJEBZCeImluHPugtcQAKqCmHWCsAqCRbqg19ophyDI QMzzsxFaA1cylewb+I1aE2M7X6WkkTXXlL6pPetLZnoTLFRaos09LiiVckFOffT4 /v5QbAvNKKBowhHd4Aj3y5r+K8wrPmZMFjer35f5p9JHw1vFR19aXzld/VhZqCIy +Op5kLCy7nhzW7tCiamAkqw8CL86H+sxdLYFXQCpcTA1Su0sKIRDD1a/praQvu/Z FxcFtsP3V124w7AuD/qRWoA/C3oRwuw9JnKrRTLk+MJftmrnji2c5ac4vpxQ+Dpb 1KbbWk66t4K2SDVuMy5DaTJCPjIOt0fs5zh/jfsG2mvaEFUQ4ZdTf5WVeeQ5Sw/O VlAW5rdrAGLQDl6ju0Tc/Fcxzi2Qv9IaeOh6aKeHGRHGvLEOjofqU66yU+ItaPhh pIrjKK73agcZgwvfGPFXag+xKnTo6/SoVJeTD5sNWk2Vm7bCETCqTCrIt94hL8FJ JGa0O4TuV93CnFVwSPgpbdN7FO0CehjU8Tdlcsvvot+CZT0p1VtT8/hJ2BM1MxS2 sbpgPqN+XZJf+2MDoTlJrJa2p9Dm++jKXMZpAd5VnGDbt8lAHItuEKLe3Jrh1i3s q9vSQKayHcpE9NRuEKL/IaFEuUwR3sKLbbVVX7ELGEiaNT3nx+I/0a0qJzY3m34j RIO8Fa+1/RgdtLrL0lRT =DaAb -----END PGP SIGNATURE----- --=-T37PYx4Dr4+mWTWfVlcl-- --===============7366772114465627862== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7366772114465627862==--