From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 0/2] tools/libs: don't use alloca(3)
Date: Thu, 18 Aug 2016 01:39:08 +0200
Message-ID: <1471477148.6806.26.camel@citrix.com>
References: <1471444382-30409-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2155313227918747135=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=0307391e5=dario.faggioli@citrix.com>)
 id 1baAQi-0008Vv-RX
 for xen-devel@lists.xenproject.org; Wed, 17 Aug 2016 23:39:28 +0000
In-Reply-To: <1471444382-30409-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============2155313227918747135==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-HlAWRIeQ/GgC9FJ9Uq7S"

--=-HlAWRIeQ/GgC9FJ9Uq7S
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2016-08-17 at 15:33 +0100, Wei Liu wrote:
> Wei Liu (2):
> =C2=A0 libs/gnttab: do not use alloca(3)
> =C2=A0 libs/foreignmemory: do not use alloca(3)
>=20
FWIW, both patches:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Out of curiosity, I've tried to figure out what the advantage was in
using alloca() instead of mmap(), in case of mappings smaller than
PAGE_SIZE (did also a small bit of archaeology but that didn't help
either).

Oh, well.

Regards,
Dario
--=C2=A0
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-HlAWRIeQ/GgC9FJ9Uq7S
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJXtPWcAAoJEBZCeImluHPuXngQAL3AteSwppsVjI49gids4kTt
YlFFwQ+udBiZR9Tl713m5I1APw0zYB+O2tZee1sTJWm/zmSmkzRiAu4/eJn0wO+O
AzmUPAYOiCCsurrUlofl3/9VZRL5W/bn/blekKVjZBmXtszdAGt+vaXAYQUngXgX
pXmu3KAAC3d6Y9kTQvR41hITQmnLwOVvAwMhJ+7tDDedNATDcu1QBgJUKI+3Vykm
hDYnrfRGkps6qeMIw+0QOJC63H7/coPs4bEO5D3GVAinpwXL+xGFJPDY2t+wkeEJ
WkMwK4GqTSlucFH9gpSg5fzowNASVLcTEFvu8OoszR3PJcU+2zL2qMaWEKH/6eAD
Pgzh3SnYmNHxOSk3/9PCUAVNJ73pai62eukZAq5MUgY7NBY3U4C/GDOkyqS6PtRz
6k/sAnoCPcB/JcoPj/dzS5cJUF1Ez7GSfWcrlu6ojLqDN8zHQGtmLyVJ8wXNPqsK
wl9jWNeLwCeswcJvX6hm/Uksg7pEJeVRgd694uyQRC7lINNRir4NA1rqUv8ol2iN
TDUArwQf1MnZinW/OL51aXQ5/lcJr8MXC/ypR9NqDXY87KtjJs5KUlsPve7cVUd9
FY4aSuOEdRXAyk7aeJGhkQAlROMSvKQYtXv9BtVjJYMuUzcWvZDoOsO9yAVyHse1
9KZFbw5GN8Z6szQ45elq
=DN1K
-----END PGP SIGNATURE-----

--=-HlAWRIeQ/GgC9FJ9Uq7S--


--===============2155313227918747135==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============2155313227918747135==--