From: Dario Faggioli <dario.faggioli@citrix.com>
To: Feng Wu <feng.wu@intel.com>, xen-devel@lists.xen.org
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
kevin.tian@intel.com, jbeulich@suse.com
Subject: Re: [PATCH v3 2/6] VMX: Properly handle pi when all the assigned devices are removed
Date: Tue, 6 Sep 2016 10:58:55 +0200 [thread overview]
Message-ID: <1473152335.19612.89.camel@citrix.com> (raw)
In-Reply-To: <1472615791-8664-3-git-send-email-feng.wu@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1583 bytes --]
On Wed, 2016-08-31 at 11:56 +0800, Feng Wu wrote:
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -158,14 +158,12 @@ static void vmx_pi_switch_to(struct vcpu *v)
> pi_clear_sn(pi_desc);
> }
>
Not terribly important, but what about calling this:
> -static void vmx_pi_do_resume(struct vcpu *v)
> +static void vmx_pi_remove_vcpu_from_blocking_list(struct vcpu *v)
vmx_pi_list_del() or vmx_pi_list_remove()
> @@ -198,6 +196,21 @@ static void vmx_pi_do_resume(struct vcpu *v)
> spin_unlock_irqrestore(pi_blocking_list_lock, flags);
> }
>
> +static void vmx_pi_do_resume(struct vcpu *v)
> +{
> + ASSERT(!test_bit(_VPF_blocked, &v->pause_flags));
> +
> + vmx_pi_remove_vcpu_from_blocking_list(v);
> +}
> +
And this:
> +static void vmx_pi_blocking_cleanup(struct vcpu *v)
>
vmx_pi_list_cleanup()
etc.?
I.e., using shorter and more consistent names.
> +{
> + if ( !iommu_intpost )
> + return;
> +
At least as far as this patch is concerned, you are only calling this
function from vmx_pi_hooks_deassing() which already checks at the very
beginning iommu_intpost to be true, or it returns, and you won't get
here.
So you don't need to re-check the same thing here.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-06 8:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 3:56 [PATCH v3 0/6] VMX: Properly handle pi descriptor and per-cpu blocking list Feng Wu
2016-08-31 3:56 ` [PATCH v3 1/6] VMX: Statically assign two PI hooks Feng Wu
2016-09-01 8:16 ` Jan Beulich
2016-09-01 9:13 ` Wu, Feng
2016-09-01 9:23 ` Jan Beulich
2016-09-01 9:38 ` Wu, Feng
2016-09-06 8:42 ` Dario Faggioli
2016-09-06 9:53 ` Wu, Feng
2016-08-31 3:56 ` [PATCH v3 2/6] VMX: Properly handle pi when all the assigned devices are removed Feng Wu
2016-09-01 8:21 ` Jan Beulich
2016-09-01 9:22 ` Wu, Feng
2016-09-01 10:23 ` Jan Beulich
2016-09-01 13:12 ` Wu, Feng
2016-09-06 8:58 ` Dario Faggioli [this message]
2016-08-31 3:56 ` [PATCH v3 3/6] VMX: Cleanup PI per-cpu blocking list when vcpu is destroyed Feng Wu
2016-09-06 9:21 ` Dario Faggioli
2016-09-06 23:27 ` Wu, Feng
2016-08-31 3:56 ` [PATCH v3 4/6] Pause/Unpause the domain before/after assigning PI hooks Feng Wu
2016-09-01 8:29 ` Jan Beulich
2016-09-02 1:46 ` Wu, Feng
2016-09-02 7:04 ` Jan Beulich
2016-09-02 7:31 ` Wu, Feng
2016-09-02 8:16 ` Jan Beulich
2016-09-02 8:40 ` Wu, Feng
2016-09-02 9:25 ` Jan Beulich
2016-09-02 10:30 ` Wu, Feng
2016-09-02 10:45 ` Jan Beulich
2016-09-02 13:15 ` Wu, Feng
2016-09-02 13:54 ` Jan Beulich
2016-09-05 3:11 ` Wu, Feng
2016-09-05 9:27 ` Jan Beulich
2016-09-14 2:23 ` Wu, Feng
2016-09-14 8:46 ` Jan Beulich
2016-09-14 14:51 ` Dario Faggioli
2016-09-18 8:37 ` Wu, Feng
2016-09-19 23:12 ` Dario Faggioli
2016-09-20 0:48 ` Wu, Feng
2016-09-20 7:31 ` Jan Beulich
2016-09-20 7:53 ` Wu, Feng
2016-09-20 8:13 ` Dario Faggioli
2016-09-20 8:18 ` Wu, Feng
2016-09-23 14:19 ` Jan Beulich
2016-09-26 2:53 ` Wu, Feng
2016-08-31 3:56 ` [PATCH v3 5/6] VT-d: No need to set irq affinity for posted format IRTE Feng Wu
2016-09-01 8:38 ` Jan Beulich
2016-09-02 1:58 ` Wu, Feng
2016-08-31 3:56 ` [PATCH v3 6/6] VMX: Fixup PI descritpor when cpu is offline Feng Wu
2016-09-01 8:48 ` Jan Beulich
2016-09-02 3:25 ` Wu, Feng
2016-09-02 7:08 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473152335.19612.89.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=feng.wu@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).