xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>
Subject: [OSSTEST PATCH v3 16/25] BuildSupport: move buildcmd_stamped_logged here
Date: Tue, 6 Sep 2016 14:09:31 +0100	[thread overview]
Message-ID: <1473167380-957-17-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1473167380-957-1-git-send-email-wei.liu2@citrix.com>

... so that other build scripts can use it, too.

It now accepts one more parameter called "component" to be useful in
other build scripts.

No functional change.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/BuildSupport.pm | 15 +++++++++++++++
 ts-xen-build            | 20 +++-----------------
 2 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/Osstest/BuildSupport.pm b/Osstest/BuildSupport.pm
index d59eace..d005ca9 100644
--- a/Osstest/BuildSupport.pm
+++ b/Osstest/BuildSupport.pm
@@ -36,6 +36,7 @@ BEGIN {
                       $whhost $ho
 
                       builddirsprops
+                      buildcmd_stamped_logged
                       $builddir $makeflags
 
                       prepbuilddirs
@@ -56,6 +57,20 @@ our ($whhost,$ho);
 our ($builddir,$makeflags);
 our ($xendist);
 
+sub buildcmd_stamped_logged ($$$$$$) {
+    my ($timeout, $component, $stampname, $prefix, $cmd, $suffix) = @_;
+    target_cmd_build($ho, $timeout, $builddir, <<END);
+        cd $component
+        $prefix
+        ( $cmd 2>&1 &&             touch ../$stampname-ok-stamp
+        ) |tee ../$stampname-log
+        test -f ../$stampname-ok-stamp
+        $suffix
+        echo ok.
+END
+#/;
+}
+
 sub selectbuildhost {
     # pass \@ARGV
     my ($av) = @_;
diff --git a/ts-xen-build b/ts-xen-build
index d0b7612..07a69ec 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -108,20 +108,6 @@ END
                );
 }
 
-sub buildcmd_stamped_logged ($$$$$) {
-    my ($timeout, $stampname, $prefix, $cmd, $suffix) = @_;
-    target_cmd_build($ho, $timeout, $builddir, <<END);
-        cd xen
-        $prefix
-        ( $cmd 2>&1 &&             touch ../$stampname-ok-stamp
-        ) |tee ../$stampname-log
-        test -f ../$stampname-ok-stamp
-        $suffix
-        echo ok.
-END
-#/;
-}
-
 sub build () {
     my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
     my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";
@@ -130,7 +116,7 @@ sub build () {
     my $configure_suffix = $r{cmdsuffix_configure} // '';
     my $make_prefix =      $r{cmdprefix_make}      // '';
 
-    buildcmd_stamped_logged(600, 'configure', <<END,<<END,<<END);
+    buildcmd_stamped_logged(600, 'xen', 'configure', <<END,<<END,<<END);
             if test -f configure; then
                 if grep -q -- $xend_opt tools/configure ; then
 		    xend=$xend_opt
@@ -145,13 +131,13 @@ END
 END
 #/;
 
-    buildcmd_stamped_logged(600, 'kconfig', '',<<END,'') if $dokconfig;
+    buildcmd_stamped_logged(600, 'xen', 'kconfig', '',<<END,'') if $dokconfig;
             if test -f xen/Kconfig; then
                 $make_prefix make -C xen olddefconfig
             fi
 END
 
-    buildcmd_stamped_logged(9000, 'build', '',<<END,'');
+    buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
             $make_prefix make $makeflags @ARGV
 END
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-09-06 13:16 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 13:09 [OSSTEST PATCH v3 00/25] Integrate XTF into OSSTest Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 01/25] Executive: Previous duration estimator: use overall time, not sum of steps Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 02/25] ts-hosts-allocate-Executive: Replace some odd commas with semicolons Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 03/25] sg-run-job: Add emacs mode comment Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 04/25] step status skip: Ignore in cs-bisection-step Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 05/25] step status skip: Ignore in report_run_getinfo Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 06/25] step status skip: Implement in sg-report-flight Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 07/25] ts-hosts-allocate-Executive: pass $plan to hid_find_possibilities Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 08/25] ts-hosts-allocate-Executive: Support diverse-CLASS hostflag Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 09/25] DO NOT APPLY make-flight-diverse-test: test case for " Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 10/25] Executive: Support substeps Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 11/25] DO NOT APPLY make-flight-substep-test Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 12/25] DO NOT APPLY provide ts-substep-test Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 13/25] ts-xen-build: always compile in FEP support Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 14/25] ap-common: add xtf tree Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 15/25] DO NOT APPLY point xtf to my personal tree Wei Liu
2016-09-06 13:09 ` Wei Liu [this message]
2016-09-06 13:09 ` [OSSTEST PATCH v3 17/25] Introduce ts-xtf-build Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 18/25] sg-run-job: create xtf build recipe Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 19/25] Introduce ts-xtf-install Wei Liu
2016-09-06 14:01   ` Ian Jackson
2016-09-06 13:09 ` [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job for 4.4 onwards Wei Liu
2016-09-06 14:06   ` Ian Jackson
2016-09-08 17:00     ` Wei Liu
2016-09-08 17:41       ` Ian Jackson
2016-09-08 18:11         ` Wei Liu
2016-09-09 10:09           ` Ian Jackson
2016-09-06 13:09 ` [OSSTEST PATCH v3 21/25] Introduce ts-xtf-fep Wei Liu
2016-09-06 14:07   ` Ian Jackson
2016-09-06 13:09 ` [OSSTEST PATCH v3 22/25] Introduce ts-xtf-run Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 23/25] sg-run-job: test-xtf recipe Wei Liu
2016-09-06 13:09 ` [OSSTEST PATCH v3 24/25] make-flight: create 5 xtf jobs Wei Liu
2016-09-08 17:01   ` Wei Liu
2016-09-08 17:41     ` Ian Jackson
2016-09-06 13:09 ` [OSSTEST PATCH v3 25/25] Create XTF branch Wei Liu
2016-09-06 14:03   ` Ian Jackson
2016-09-06 19:16     ` Wei Liu
2016-09-08 14:47       ` Ian Jackson
2016-09-08 17:07         ` Wei Liu
2016-09-08 17:45           ` Ian Jackson
2016-09-08 18:07             ` Wei Liu
2016-09-09 10:04               ` Ian Jackson
2016-09-06 19:14   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473167380-957-17-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).