From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 1/1] xen: move TLB-flush filtering out into populate_physmap during vm creation Date: Thu, 8 Sep 2016 16:49:01 +0200 Message-ID: <1473346141.19612.164.camel@citrix.com> References: <1473312603-28581-1-git-send-email-dongli.zhang@oracle.com> <20160908105047.GB12697@citrix.com> <1473332500.19612.145.camel@citrix.com> <20160908111119.GC12697@citrix.com> <07306b9e-9bd5-0276-4df7-ffb1c8c0e792@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9004946516883185885==" Return-path: In-Reply-To: <07306b9e-9bd5-0276-4df7-ffb1c8c0e792@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , Wei Liu Cc: sstabellini@kernel.org, george.dunlap@eu.citrix.com, Dongli Zhang , tim@xen.org, xen-devel@lists.xen.org, david.vrabel@citrix.com, jbeulich@suse.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============9004946516883185885== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-K5F0e2e2mxGP03754sfq" --=-K5F0e2e2mxGP03754sfq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-09-08 at 13:19 +0200, Juergen Gross wrote: > The first scheduling is done via unpausing the domain. Why not > setting > the flag to true in that path? >=20 That could be a good idea. And in general, I'm all for finding a place and/or a state that better represents the condition of "setting to run this vcpu for the first time" and set the flag there, rather than re-assigning 1 to an "already_scheduled" flag each an every time we go through schedule() (and not for performance and optimization reason). Which domain_unpause() (or whatever) do you have in mind precisely? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-K5F0e2e2mxGP03754sfq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJX0XpeAAoJEBZCeImluHPuD1AQALeoyE5mJ9TK7WhS7tLrWyKu We9hJNHXPWQDYu27C6TU0DK1HCFS467FLJhsZEt5zNH6PBhlAnOcWdJdHqNyfcNz JSZMRAhbPm2vCkBsxZa036b6eQJdUTe4gVNaXNksR4vrXjYBvhM0B5rSvDPi0/d2 fc9S+yr0x5sfRY2VdylZS/3zt8a9m4zdN+E3ePN8oyoOX8oBp05naD1SeEV1cRhn SLa1rEw+0ouQD6Ps8YslP8o4sd+CanhR4R7mzeyBBLmPm83554AHLKqMUX9L1j5C fPSlKjm0WNLyw3daTUaDY48iW5PVjGDEW2rbizsDlMbocuzjonSaOgTF95O1aGlE nZ3tfHDgNYmEom8pfXMtUW2sUuIeUe2Ii9xuS2GQe4/2NkNFJ3eHsQ0LE0ONnl3K lTo3S5XQMTJk9g9rLXEaa4zlQfoqMsJ9kNCuxqrkuAXMfm3hXzvOawoDs53KK6vS SBqtMyh8o83j0VjVfNu59JpJBPkcrTQgw9OhZYqoES2UMerjAn4FdgM1zWO2pHjd UL0G680ACZdCyecJoJs3uLOMgsWfopdQz/Txrb0PDylSbgUAszi1rtTfDwav99AY BZUVOruounAsT+guhXkMftiZA3/tTH30RTCG/pP98AwFWxAakbeiUJd9aSwN45qC PQ6e+/iSMDlxz45Vozwr =Vt/X -----END PGP SIGNATURE----- --=-K5F0e2e2mxGP03754sfq-- --===============9004946516883185885== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============9004946516883185885==--