From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 1/1] xen: move TLB-flush filtering out into populate_physmap during vm creation Date: Thu, 8 Sep 2016 17:53:46 +0200 Message-ID: <1473350026.19612.170.camel@citrix.com> References: <1473312603-28581-1-git-send-email-dongli.zhang@oracle.com> <57D1A188020000780010D3E8@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8049844127300170247==" Return-path: In-Reply-To: <57D1A188020000780010D3E8@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Dongli Zhang Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com, george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org --===============8049844127300170247== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-mjbNfMUuHDwVIk9mX+3e" --=-mjbNfMUuHDwVIk9mX+3e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-09-08 at 09:36 -0600, Jan Beulich wrote: > >=20 > > >=20 > > > >=20 > > > > On 08.09.16 at 07:30, wrote: > > --- a/xen/include/xen/sched.h > > +++ b/xen/include/xen/sched.h > > @@ -474,6 +474,9 @@ struct domain > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned int gues= t_request_enabled=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: 1; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned int gues= t_request_sync=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0:= 1; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} monitor; > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0/* set to 1 the first time this domain gets sc= heduled. */ > > +=C2=A0=C2=A0=C2=A0=C2=A0bool_t already_scheduled; > Did you go through and check that there is nothing this information > can already get derived from? I can't immediately point you at > anything, but it feels like there should.=20 > Indeed. And if there isn't and we need to do add our own flagging, isn't there a better way and place where to put it (e.g., what Juergen and Andrew are hinting at)? > And if indeed there isn't, > then - to extend on someone else's comments (I think it was Dario) > - please use plain bool in new additions. >=20 It's Wei that commented about bool-s use in the patch. :-) Regards, Dario --=C2=A0 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-mjbNfMUuHDwVIk9mX+3e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJX0YmLAAoJEBZCeImluHPuVIUQAJqe7fGVb/KWQ4ZW7MSH551W vm2XvrjarCmYgmyof0Ky088UOGpaVJxTP+yl0zGw75hqMfGO2KGpmQqLu2WYBIgh wawDOWLeNs83N2abrJc3y9AW/6dWEtE6X+HaX5WhaFXjkJ/pzj61FFtqR/YBvXh+ zOs/3MmUKdCqxE25KVU7L1eaKbD28pnX+2YUUBw7pPkhgSRj12H2BWw2Y4eK3svl XISzG0UbmGLlGY7ZR0blXDNvwAuym4iW/1gZN5OmSZcpp72LJ8Jr9Ld83KJQRbrd 05zNlD2jfSrQip6zeHqTD56v+eSn+s3znrrjDfXY11vZkzRHgdiComd1rQ+trxYG BbpDzh8I1I3RaLltVUKS5KwzgOzDPeGwKq993Kwcy2fFzTn+x6CDgjm1jy9Gbc2j DgzHwvLu3xbE+3q9XvuyHWU5gMXuNW0jVnNDQcV1NedWL3QnUNLhucb+Eeg1MDMV Yel0xwxEjtPiK1owIZgEP8Y60wTm7PkU+NUKJtWq5N5hxwOSFrdzpUkVdW4qUayF y9MC/ajsKHWpVohwqsoWKWvmt6pEfsJVoiAvJ9mwMGjfKdA/yX3ENWm7yqPzyhHQ ygCLdsX3MEgSmQ+xbVfVZdS0F+grCF+s5s0b+CtRZXoS1FJEIUUYq51iXM2fa5X2 Cnfi06hSWQXA7GU/FR0e =UqNW -----END PGP SIGNATURE----- --=-mjbNfMUuHDwVIk9mX+3e-- --===============8049844127300170247== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============8049844127300170247==--