From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 0/6] Fix multiple issues with xsave state handling on migrate
Date: Mon, 12 Sep 2016 17:21:23 +0100 [thread overview]
Message-ID: <1473697289-4289-1-git-send-email-andrew.cooper3@citrix.com> (raw)
Patch 5 is the primary bugfix of this series, which is broken in Xen 4.7 as
well as master. There are multiple latent security issues which would be
exposed at the point support for the first compressed xsave state was added,
but are in currently-dead code.
Changes from v1:
* Inline and remove get_xsave_addr(). This simplifies the logic.
* Whitespace & alignment fixes.
* Use a shadow variable in hvm_load_cpu_xsave_states()
* Drop the TODO BUG_ON() from compress_xsave_states()
Andrew Cooper (6):
x86/domctl: Introduce PV_XSAVE_HDR_SIZE and remove its opencoding
x86/domctl: Fix TOCTOU race with the use of XEN_DOMCTL_getvcpuextstate
x86/domctl: Simplfy XEN_DOMCTL_getvcpuextstate when xsave is not in use
x86/xstate: Fix latent bugs in expand_xsave_states()
x86/domctl: Fix migration of guests which are not using xsave
x86/xstate: Fix latent bugs in compress_xsave_states()
xen/arch/x86/domctl.c | 62 ++++++++++++++++++++-----------
xen/arch/x86/hvm/hvm.c | 27 +++++++++++---
xen/arch/x86/xstate.c | 87 ++++++++++++++++++++++++++++----------------
xen/include/asm-x86/xstate.h | 6 +++
4 files changed, 124 insertions(+), 58 deletions(-)
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-09-12 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 16:21 Andrew Cooper [this message]
2016-09-12 16:21 ` [PATCH v2 1/6] x86/domctl: Introduce PV_XSAVE_HDR_SIZE and remove its opencoding Andrew Cooper
2016-09-12 16:21 ` [PATCH v2 2/6] x86/domctl: Fix TOCTOU race with the use of XEN_DOMCTL_getvcpuextstate Andrew Cooper
2016-09-12 16:21 ` [PATCH v2 3/6] x86/domctl: Simplfy XEN_DOMCTL_getvcpuextstate when xsave is not in use Andrew Cooper
2016-09-12 16:21 ` [PATCH v2 4/6] x86/xstate: Fix latent bugs in expand_xsave_states() Andrew Cooper
2016-09-13 8:23 ` Jan Beulich
2016-09-13 9:31 ` Andrew Cooper
2016-09-12 16:21 ` [PATCH v2 5/6] x86/domctl: Fix migration of guests which are not using xsave Andrew Cooper
2016-09-12 16:21 ` [PATCH v2 6/6] x86/xstate: Fix latent bugs in compress_xsave_states() Andrew Cooper
2016-09-13 8:27 ` Jan Beulich
2016-09-13 9:35 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473697289-4289-1-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).