From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 03/24] xen: credit1: return the 'time remaining to the limit' as next timeslice. Date: Wed, 14 Sep 2016 15:54:05 +0200 Message-ID: <1473861245.6339.132.camel@citrix.com> References: <147145358844.25877.7490417583264534196.stgit@Solace.fritz.box> <147145427423.25877.10573077044748803993.stgit@Solace.fritz.box> <2436cc42-80bc-b51a-8fca-366b3d81537f@citrix.com> <1473699658.6339.26.camel@citrix.com> <497c46c4-7f83-d1b3-304f-04b9eacbf135@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0039417801403216457==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkAdw-0005dG-Tk for xen-devel@lists.xenproject.org; Wed, 14 Sep 2016 13:54:29 +0000 In-Reply-To: <497c46c4-7f83-d1b3-304f-04b9eacbf135@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , xen-devel@lists.xenproject.org Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org --===============0039417801403216457== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-aKti+Vf75RtLDFSYL6Ol" --=-aKti+Vf75RtLDFSYL6Ol Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-09-14 at 10:34 +0100, George Dunlap wrote: > On 12/09/16 18:00, Dario Faggioli wrote: > >=C2=A0 > > I also agree on the fact that most of the times ratelimit_us and > > MIN_TIMER will be close enough (like in the example above) that it > > won't probably matter much... but if someone set ratelimit_us to > > something higher (say, 10ms --we accept values as big as the > > timeslice, > > which is 30ms b default) it may matter a bit. > >=20 > > What do you think? > >=20 > > If we decide not to care, and leave things as they are, I'd add a > > comment saying that code is like that on purpose, so we won't trip > > over > > this again in 1 or 2 years. :-) > Yeah, I think while we're thinking about it we might as well add in > the > MIN_TIMER thing you mention above (if you don't mind doing it). >=20 Sure I don't mind. I'll do it. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-aKti+Vf75RtLDFSYL6Ol Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJX2VZ+AAoJEBZCeImluHPuXPkP/2/bPWbgKTv2AI/T5+zxgj2a rXiK/K0xSOFUbjSgFM7fmM5YFIkqugByacsxbSvrGmRhHxRa/Hr7ADt2jBuTrl6s OCCNxdQ3O022KI0ma7EdFXBk4E2WQAnSCZge9lBXSY7ZKNfuTvNyfJIKjy9foSQx xAEmT8KwBkG1jLwT3MR8TwHn1e0dmArxVGhWSEOeYUO3XLVwNbxP+RxKnAT8POsN 72oJ+srbMmODyV6wYqNJDX/HYacbPRlNB+x8kw33BLmoTcSLf3ay7apCzZkByKHN Gh7trUSf2rwPstVZd5xw+0U+qw8TWzsXy/qvcg5z/Cv6I206L0TkKZ1+Z1fDdIBe Td7raM3E3Tpzgp20JbNGESb9BtJGDO+FQqTaKJRHMktIgWkG76GembbOWFvWhWsL DGOU/zSa54u4ZsSKtkrBOU3F5Gg43J+A3vo6sxbXdHGQvwyTBpdNpBTAnxkRCAse gDtl8O6JwfdIHs86yWwXz0vxsYNoJTaBAxHFoOXFAwqlVu0wWXtE6rEBJHBOl9F0 DVN6jlSwKCLT5STuEazPrJeHs8pgC5+Zq01UinffCThb9a2Bov5SW1rAD9K9NDt8 qlSTWvpLFyPuozvdCtHt3QAUqZ18bpag0BPnHMg7TEHvAR3MA6vNf8JtTdBPcUUE hMMQdDwFBNbf3r16myMc =j72L -----END PGP SIGNATURE----- --=-aKti+Vf75RtLDFSYL6Ol-- --===============0039417801403216457== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0039417801403216457==--