From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 4/6] Pause/Unpause the domain before/after assigning PI hooks Date: Tue, 20 Sep 2016 10:13:34 +0200 Message-ID: <1474359214.4393.159.camel@citrix.com> References: <1472615791-8664-1-git-send-email-feng.wu@intel.com> <1472615791-8664-5-git-send-email-feng.wu@intel.com> <57C8030F020000780010ABEF@prv-mh.provo.novell.com> <57C94099020000780010B115@prv-mh.provo.novell.com> <57C95162020000780010B1B3@prv-mh.provo.novell.com> <57C961B3020000780010B27E@prv-mh.provo.novell.com> <57C97470020000780010B354@prv-mh.provo.novell.com> <57C9A0C1020000780010B642@prv-mh.provo.novell.com> <1473864713.6339.142.camel@citrix.com> <1474326728.4393.90.camel@citrix.com> <57E101F7020000780011075A@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1686487950807237411==" Return-path: In-Reply-To: <57E101F7020000780011075A@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: "george.dunlap@eu.citrix.com" , "andrew.cooper3@citrix.com" , Kevin Tian , Feng Wu , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============1686487950807237411== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-e6ZYRsnZuwNNawv3DjRe" --=-e6ZYRsnZuwNNawv3DjRe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-09-20 at 01:31 -0600, Jan Beulich wrote: > > > > On 20.09.16 at 01:12, wrote: > > How's possible for the solution here to be "either remove the > > ASSERT() > > _OR_ change the code"? That really makes few sense to me... :-O >=20 > I disagree: Whether fixing/removing an ASSERT() that triggered or > adjusting other code to make the ASSERT() not trigger can indeed > both be an option, and may to some degree be a matter of taste. > Yes, of course this is a possibility... I thought it was clear that I was simplifying things, but maybe I was simplifying too much, or "just" expressed myself bad. What I wasn't clear about was whether it is _correctness_ that is at risk or not. And that's right because I thought we established already that this wasn't a correctness issue, while it looked to me, from reading the discussion, that it actually may be. My bad again, for sure, sorry. Now I'll go back to the code to fix my misconceptions and (hopefully) be able to make myself more useful. :-) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-e6ZYRsnZuwNNawv3DjRe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJX4O+vAAoJEBZCeImluHPuE00P/207Nk+9kUjuYVhMISa0mj0F bS4GKWE8HRJPw+3U7bBZL9hdBEx3mfX3QuBcU+5A6PZzSrn0qGxh2MCMd2oIeX14 lQriP+9P3AUOxTtrvdh7J9GEEvZzWFY+/6/6oL5/d5sFCBmloabO0AvkWpIxhWWV xNMGegknDcvE4tIS1NlHP0eGeWFA1emagOyQSQmtbYqJnNuJrh534mKHxA/ug5jC 9CTE9JxPRWjqzMc/ywHaBp43eDtMwej3595Eh3Jhg3P8R0UTrbMJBvi3wo8qUBcn nYPRLgLrc8gFPZqqKlrfPri95uhlbQIp82kPl1eeABMLTM3+qSxZd8q9EQS+oGr/ iomepvsiemVzydz0vxONntuoWNvvHqcOj+k3gFPAHQE24BpEjQf2zhIvv0wGNeyi zMjCLq8d2CoByFZhEvmJQf5dmzdldj8uWe5tFqdolWEuE6BxXhzpjFRh9mg71To3 CJd8SFGMj9+CHCdKBe0c/hmYXgTjuxchDQGW/3d2Kc0aYdZlX3cOPKQGtKtTu5Ok H9HxCRVGvOjHnrPccrn20kk8kC2nbjpiYVThj4VnuMuUeazphyPH7A+pkQuRGbJF dRnccWM2jLwbp34rY0rX0vzKoO0J+YQ3Q9xTw9SWRfqXcmdddJ2hb3D/BZd0Nmbh XX8eZxp4cCvzw6VqMKRp =R2Q9 -----END PGP SIGNATURE----- --=-e6ZYRsnZuwNNawv3DjRe-- --===============1686487950807237411== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1686487950807237411==--