From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: konrad@kernel.org, xen-devel@lists.xenproject.org,
ross.lagerwall@citrix.com
Cc: andrew.cooper3@citrix.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v7 4/5] livepatch: Drop _jmp from arch_livepatch_[apply, revert]_jmp
Date: Wed, 21 Sep 2016 12:57:09 -0400 [thread overview]
Message-ID: <1474477030-10722-5-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1474477030-10722-1-git-send-email-konrad.wilk@oracle.com>
With "livepatch: NOP if func->new_addr is zero." that name
makes no more sense as we also NOP now.
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
v7: New submission.
---
xen/arch/arm/livepatch.c | 4 ++--
xen/arch/x86/livepatch.c | 4 ++--
xen/common/livepatch.c | 4 ++--
xen/include/xen/livepatch.h | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c
index 755f596..7f067a0 100644
--- a/xen/arch/arm/livepatch.c
+++ b/xen/arch/arm/livepatch.c
@@ -21,11 +21,11 @@ int arch_livepatch_verify_func(const struct livepatch_func *func)
return -ENOSYS;
}
-void arch_livepatch_apply_jmp(struct livepatch_func *func)
+void arch_livepatch_apply(struct livepatch_func *func)
{
}
-void arch_livepatch_revert_jmp(const struct livepatch_func *func)
+void arch_livepatch_revert(const struct livepatch_func *func)
{
}
diff --git a/xen/arch/x86/livepatch.c b/xen/arch/x86/livepatch.c
index d5e7174..b0d81d7 100644
--- a/xen/arch/x86/livepatch.c
+++ b/xen/arch/x86/livepatch.c
@@ -46,7 +46,7 @@ int arch_livepatch_verify_func(const struct livepatch_func *func)
return 0;
}
-void arch_livepatch_apply_jmp(struct livepatch_func *func)
+void arch_livepatch_apply(struct livepatch_func *func)
{
uint8_t *old_ptr;
uint8_t insn[sizeof(func->opaque)];
@@ -75,7 +75,7 @@ void arch_livepatch_apply_jmp(struct livepatch_func *func)
memcpy(old_ptr, insn, len);
}
-void arch_livepatch_revert_jmp(const struct livepatch_func *func)
+void arch_livepatch_revert(const struct livepatch_func *func)
{
memcpy(func->old_addr, func->opaque, livepatch_insn_len(func));
}
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index ed41f39..9d2e86d 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -1033,7 +1033,7 @@ static int apply_payload(struct payload *data)
}
for ( i = 0; i < data->nfuncs; i++ )
- arch_livepatch_apply_jmp(&data->funcs[i]);
+ arch_livepatch_apply(&data->funcs[i]);
arch_livepatch_revive();
@@ -1062,7 +1062,7 @@ static int revert_payload(struct payload *data)
}
for ( i = 0; i < data->nfuncs; i++ )
- arch_livepatch_revert_jmp(&data->funcs[i]);
+ arch_livepatch_revert(&data->funcs[i]);
arch_livepatch_revive();
diff --git a/xen/include/xen/livepatch.h b/xen/include/xen/livepatch.h
index 174af06..b7f66d4 100644
--- a/xen/include/xen/livepatch.h
+++ b/xen/include/xen/livepatch.h
@@ -86,8 +86,8 @@ unsigned int livepatch_insn_len(const struct livepatch_func *func)
int arch_livepatch_quiesce(void);
void arch_livepatch_revive(void);
-void arch_livepatch_apply_jmp(struct livepatch_func *func);
-void arch_livepatch_revert_jmp(const struct livepatch_func *func);
+void arch_livepatch_apply(struct livepatch_func *func);
+void arch_livepatch_revert(const struct livepatch_func *func);
void arch_livepatch_post_action(void);
void arch_livepatch_mask(void);
--
2.4.11
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-21 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 16:57 [PATCH v7] Livepatch fixes and general features for Xen 4.8 Konrad Rzeszutek Wilk
2016-09-21 16:57 ` [PATCH v7 1/5] livepatch: Disallow applying after an revert Konrad Rzeszutek Wilk
2016-09-22 9:21 ` Jan Beulich
2016-09-22 10:16 ` Konrad Rzeszutek Wilk
2016-09-22 23:55 ` Konrad Rzeszutek Wilk
2016-09-23 6:18 ` Jan Beulich
2016-09-21 16:57 ` [PATCH v7 2/5] livepatch: Add limit of 2MB to payload .bss sections Konrad Rzeszutek Wilk
2016-09-22 9:21 ` Jan Beulich
2016-09-21 16:57 ` [PATCH v7 3/5] livepatch: NOP if func->new_addr is zero Konrad Rzeszutek Wilk
2016-09-22 9:23 ` Jan Beulich
2016-09-21 16:57 ` Konrad Rzeszutek Wilk [this message]
2016-09-22 9:24 ` [PATCH v7 4/5] livepatch: Drop _jmp from arch_livepatch_[apply, revert]_jmp Ross Lagerwall
2016-09-21 16:57 ` [PATCH v7 5/5] livepach: Add .livepatch.hooks functions and test-case Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474477030-10722-5-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=konrad@kernel.org \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).