* [PATCH] xenpv: Fix qemu_uuid compiling error
@ 2016-09-27 9:20 Fam Zheng
2016-09-27 15:08 ` Eric Blake
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2016-09-27 9:20 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Perard, xen-devel, Stefano Stabellini
9c5ce8db2 switched the type of qemu_uuid and this should have followed.
Fix it.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
hw/xenpv/xen_domainbuild.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c
index b439b0e..457a897 100644
--- a/hw/xenpv/xen_domainbuild.c
+++ b/hw/xenpv/xen_domainbuild.c
@@ -232,7 +232,7 @@ int xen_domain_build_pv(const char *kernel, const char *ramdisk,
unsigned long xenstore_mfn = 0, console_mfn = 0;
int rc;
- memcpy(uuid, qemu_uuid, sizeof(uuid));
+ memcpy(uuid, &qemu_uuid, sizeof(uuid));
rc = xen_domain_create(xen_xc, ssidref, uuid, flags, &xen_domid);
if (rc < 0) {
fprintf(stderr, "xen: xc_domain_create() failed\n");
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xenpv: Fix qemu_uuid compiling error
2016-09-27 9:20 [PATCH] xenpv: Fix qemu_uuid compiling error Fam Zheng
@ 2016-09-27 15:08 ` Eric Blake
2016-09-29 0:03 ` Stefano Stabellini
0 siblings, 1 reply; 4+ messages in thread
From: Eric Blake @ 2016-09-27 15:08 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Anthony Perard, xen-devel, Stefano Stabellini
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On 09/27/2016 04:20 AM, Fam Zheng wrote:
> 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> Fix it.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/xenpv/xen_domainbuild.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c
> index b439b0e..457a897 100644
> --- a/hw/xenpv/xen_domainbuild.c
> +++ b/hw/xenpv/xen_domainbuild.c
> @@ -232,7 +232,7 @@ int xen_domain_build_pv(const char *kernel, const char *ramdisk,
> unsigned long xenstore_mfn = 0, console_mfn = 0;
> int rc;
>
> - memcpy(uuid, qemu_uuid, sizeof(uuid));
> + memcpy(uuid, &qemu_uuid, sizeof(uuid));
> rc = xen_domain_create(xen_xc, ssidref, uuid, flags, &xen_domid);
> if (rc < 0) {
> fprintf(stderr, "xen: xc_domain_create() failed\n");
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xenpv: Fix qemu_uuid compiling error
2016-09-27 15:08 ` Eric Blake
@ 2016-09-29 0:03 ` Stefano Stabellini
2016-09-29 3:38 ` Fam Zheng
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Stabellini @ 2016-09-29 0:03 UTC (permalink / raw)
To: Eric Blake
Cc: Anthony Perard, xen-devel, Fam Zheng, qemu-devel,
Stefano Stabellini
On Tue, 27 Sep 2016, Eric Blake wrote:
> On 09/27/2016 04:20 AM, Fam Zheng wrote:
> > 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> > Fix it.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > hw/xenpv/xen_domainbuild.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> > diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c
> > index b439b0e..457a897 100644
> > --- a/hw/xenpv/xen_domainbuild.c
> > +++ b/hw/xenpv/xen_domainbuild.c
> > @@ -232,7 +232,7 @@ int xen_domain_build_pv(const char *kernel, const char *ramdisk,
> > unsigned long xenstore_mfn = 0, console_mfn = 0;
> > int rc;
> >
> > - memcpy(uuid, qemu_uuid, sizeof(uuid));
> > + memcpy(uuid, &qemu_uuid, sizeof(uuid));
> > rc = xen_domain_create(xen_xc, ssidref, uuid, flags, &xen_domid);
> > if (rc < 0) {
> > fprintf(stderr, "xen: xc_domain_create() failed\n");
> >
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xenpv: Fix qemu_uuid compiling error
2016-09-29 0:03 ` Stefano Stabellini
@ 2016-09-29 3:38 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2016-09-29 3:38 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Anthony Perard, xen-devel, qemu-devel
On Wed, 09/28 17:03, Stefano Stabellini wrote:
> On Tue, 27 Sep 2016, Eric Blake wrote:
> > On 09/27/2016 04:20 AM, Fam Zheng wrote:
> > > 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> > > Fix it.
> > >
> > > Signed-off-by: Fam Zheng <famz@redhat.com>
> > > ---
> > > hw/xenpv/xen_domainbuild.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Queued for next pull request, thanks.
Fam
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-29 3:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-27 9:20 [PATCH] xenpv: Fix qemu_uuid compiling error Fam Zheng
2016-09-27 15:08 ` Eric Blake
2016-09-29 0:03 ` Stefano Stabellini
2016-09-29 3:38 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).