From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
samuel.thibault@ens-lyon.org, wei.liu2@citrix.com
Subject: [PATCH] minios: fix build issue with xen_*mb defines
Date: Wed, 28 Sep 2016 11:50:04 +0200 [thread overview]
Message-ID: <1475056204-29295-1-git-send-email-jgross@suse.com> (raw)
Commit e35295d724d64e6e025ec31c2e510e448b8641d1 ("mini-os: fix builds
with uncommon config settings") introduced a bug which will break
the build, as xc_minios.c will have defined those macros via
xc_private.h.
Fix this by defining the macros only if compiling a minios source.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
include/x86/os.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/x86/os.h b/include/x86/os.h
index 0f5dd6c..fbc2eeb 100644
--- a/include/x86/os.h
+++ b/include/x86/os.h
@@ -511,14 +511,14 @@ static __inline__ unsigned long __ffs(unsigned long word)
#error "Unsupported architecture"
#endif
-#endif /* ifdef __INSIDE_MINIOS */
-
/********************* common i386 and x86_64 ****************************/
#define xen_mb() mb()
#define xen_rmb() rmb()
#define xen_wmb() wmb()
#define xen_barrier() asm volatile ( "" : : : "memory")
+#endif /* ifdef __INSIDE_MINIOS */
+
#define wrmsr(msr,val1,val2) \
__asm__ __volatile__("wrmsr" \
: /* no outputs */ \
--
2.6.6
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-09-28 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 9:50 Juergen Gross [this message]
2016-09-28 10:01 ` [PATCH] minios: fix build issue with xen_*mb defines Wei Liu
2016-09-28 10:06 ` Juergen Gross
2016-09-28 10:10 ` Wei Liu
2016-09-28 10:14 ` [Minios-devel] " Juergen Gross
2016-09-28 11:07 ` Samuel Thibault
2016-09-28 11:10 ` [Minios-devel] " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475056204-29295-1-git-send-email-jgross@suse.com \
--to=jgross@suse.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).