From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH] libxc: fix out of range shift in populate_acpi_pages
Date: Wed, 28 Sep 2016 16:02:59 +0100 [thread overview]
Message-ID: <1475074979-31840-1-git-send-email-wei.liu2@citrix.com> (raw)
"unsigned int" is only 4-byte long and "4" is treated as int. The shift
would overflow. Use "unsigned long" (to match the type of idx) and
"4UL" instead.
Caught by clang compilation test.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
tools/libxc/xc_dom_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
index 87b450c..b3feb42 100644
--- a/tools/libxc/xc_dom_core.c
+++ b/tools/libxc/xc_dom_core.c
@@ -1048,7 +1048,7 @@ static int populate_acpi_pages(struct xc_dom_image *dom,
xc_interface *xch = dom->xch;
uint32_t domid = dom->guest_domid;
unsigned long idx;
- unsigned int first_high_idx = (4 << 30) >> PAGE_SHIFT; /* 4GB */
+ unsigned long first_high_idx = (4UL << 30) >> PAGE_SHIFT; /* 4GB */
for ( ; num_pages; num_pages--, extents++ )
{
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-09-28 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 15:02 Wei Liu [this message]
2016-09-28 15:22 ` [PATCH] libxc: fix out of range shift in populate_acpi_pages Boris Ostrovsky
2016-09-28 15:22 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475074979-31840-1-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).