From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 08/10] libxl: fix coding style of credit1 parameters related functions Date: Fri, 30 Sep 2016 14:04:47 +0200 Message-ID: <1475237087.5315.74.camel@citrix.com> References: <147520253247.22544.10673844222866363947.stgit@Solace.fritz.box> <147520405481.22544.7998206786104494657.stgit@Solace.fritz.box> <22510.15692.455184.207639@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0170519186373125617==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpwZ5-0007Ya-Js for xen-devel@lists.xenproject.org; Fri, 30 Sep 2016 12:05:19 +0000 In-Reply-To: <22510.15692.455184.207639@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ian Jackson Cc: George Dunlap , xen-devel@lists.xenproject.org, Wei Liu List-Id: xen-devel@lists.xenproject.org --===============0170519186373125617== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Tk+WEjp52Y47dcdZNOpq" --=-Tk+WEjp52Y47dcdZNOpq Content-Type: multipart/mixed; boundary="=-ix8Zske1mzK82139b0YZ" --=-ix8Zske1mzK82139b0YZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-09-30 at 11:24 +0100, Ian Jackson wrote: > Dario Faggioli writes ("[PATCH v2 08/10] libxl: fix coding style of > credit1 parameters related functions"): > > =C2=A0int libxl_sched_credit_params_set(libxl_ctx *ctx, uint32_t poolid= , > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0libxl_sch= ed_credit_params > > *scinfo) > > =C2=A0{ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct xen_sysctl_credit_schedule sparam; > > -=C2=A0=C2=A0=C2=A0=C2=A0int rc=3D0; > > +=C2=A0=C2=A0=C2=A0=C2=A0int r, rc; > ... > >=20 > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0scinfo->tslice_ms =3D sparam.tslice_ms; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0scinfo->ratelimit_us =3D sparam.ratelimit= _us; > > =C2=A0 > > + out: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0GC_FREE; > > -=C2=A0=C2=A0=C2=A0=C2=A0return 0; > > +=C2=A0=C2=A0=C2=A0=C2=A0return rc; >=20 > I think this is missing an assignment >=20 > =C2=A0 rc =3D 0; >=20 > on the successful exit path, just before out.=C2=A0=C2=A0Am I wrong ? >=20 Indeed it's missing. It was not necessary in v1 of this patch, so I must have failed to notice that it was, when splitting that in two. Sorry. Not sure how to proceed, so I'm attaching an updated version of the patch to this email. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-ix8Zske1mzK82139b0YZ Content-Disposition: attachment; filename="libxl-fix-coding-style-sched-param.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="libxl-fix-coding-style-sched-param.patch"; charset="UTF-8" RnJvbTogRGFyaW8gRmFnZ2lvbGkgPGRhcmlvLmZhZ2dpb2xpQGNpdHJpeC5jb20+CgpsaWJ4bDog Zml4IGNvZGluZyBzdHlsZSBvZiBjcmVkaXQxIHBhcmFtZXRlcnMgcmVsYXRlZCBmdW5jdGlvbnMK Ck1vcmUgc3BlY2lmaWNhbGx5LCB0aGUgdGhlIGVycm9yIGhhbmRsaW5nIHBhdGggaXMKbWFkZSBj b21wbGlhbnQgd2l0aCBsaWJ4bCdzIGNvZHlpbmcgc3R5bGUuCgpObyBmdW5jdGlvbmFsIGNoYW5n ZSBpbnRlbmRlZC4KClNpZ25lZC1vZmYtYnk6IERhcmlvIEZhZ2dpb2xpIDxkYXJpby5mYWdnaW9s aUBjaXRyaXguY29tPgotLS0KQ2M6IElhbiBKYWNrc29uIDxpYW4uamFja3NvbkBldS5jaXRyaXgu Y29tPgpDYzogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4KQ2M6IEdlb3JnZSBEdW5sYXAg PGdlb3JnZS5kdW5sYXBAZXUuY2l0cml4LmNvbT4KLS0tCkNoYW5nZXMgZnJvbSB2MjoKICogYWRk IGEgbWlzc2luZyAncmMgPSAwJywgYXMgbm90ZWQgZHVyaW5nIHJldmlldy4KCkNoYW5nZXMgZnJv bSB2MToKICogbmV3IHBhdGNoLCBjb250YWluaW5nIG9ubHkgdGhlIGNvZGluZyBzdHlsZSBjaGFu Z2VzIGZyb20gd2hhdCB3YXMgcGF0Y2ggMTQKICAgaW4gdjEuCgpkaWZmIC0tZ2l0IGEvdG9vbHMv bGlieGwvbGlieGwuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsLmMKaW5kZXggYTQ2YjgyNy4uZDI1NTJm OSAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGwuYworKysgYi90b29scy9saWJ4bC9saWJ4 bC5jCkBAIC01MjYwLDY1ICs1MjYwLDY5IEBAIGludCBsaWJ4bF9zY2hlZF9jcmVkaXRfcGFyYW1z X2dldChsaWJ4bF9jdHggKmN0eCwgdWludDMyX3QgcG9vbGlkLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxpYnhsX3NjaGVkX2NyZWRpdF9wYXJhbXMgKnNjaW5mbykKIHsKICAg ICBzdHJ1Y3QgeGVuX3N5c2N0bF9jcmVkaXRfc2NoZWR1bGUgc3BhcmFtOwotICAgIGludCByYzsK KyAgICBpbnQgciwgcmM7CiAgICAgR0NfSU5JVChjdHgpOwogCi0gICAgcmMgPSB4Y19zY2hlZF9j cmVkaXRfcGFyYW1zX2dldChjdHgtPnhjaCwgcG9vbGlkLCAmc3BhcmFtKTsKLSAgICBpZiAocmMg IT0gMCkgewotICAgICAgICBMT0dFKEVSUk9SLCAiZ2V0dGluZyBzY2hlZCBjcmVkaXQgcGFyYW0i KTsKLSAgICAgICAgR0NfRlJFRTsKLSAgICAgICAgcmV0dXJuIEVSUk9SX0ZBSUw7CisgICAgciA9 IHhjX3NjaGVkX2NyZWRpdF9wYXJhbXNfZ2V0KGN0eC0+eGNoLCBwb29saWQsICZzcGFyYW0pOwor ICAgIGlmIChyIDwgMCkgeworICAgICAgICBMT0dFKEVSUk9SLCAiZ2V0dGluZyBDcmVkaXQgc2No ZWR1bGVyIHBhcmFtZXRlcnMiKTsKKyAgICAgICAgcmMgPSBFUlJPUl9GQUlMOworICAgICAgICBn b3RvIG91dDsKICAgICB9CiAKICAgICBzY2luZm8tPnRzbGljZV9tcyA9IHNwYXJhbS50c2xpY2Vf bXM7CiAgICAgc2NpbmZvLT5yYXRlbGltaXRfdXMgPSBzcGFyYW0ucmF0ZWxpbWl0X3VzOwogCisg ICAgcmMgPSAwOworIG91dDoKICAgICBHQ19GUkVFOwotICAgIHJldHVybiAwOworICAgIHJldHVy biByYzsKIH0KIAogaW50IGxpYnhsX3NjaGVkX2NyZWRpdF9wYXJhbXNfc2V0KGxpYnhsX2N0eCAq Y3R4LCB1aW50MzJfdCBwb29saWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bGlieGxfc2NoZWRfY3JlZGl0X3BhcmFtcyAqc2NpbmZvKQogewogICAgIHN0cnVjdCB4ZW5fc3lz Y3RsX2NyZWRpdF9zY2hlZHVsZSBzcGFyYW07Ci0gICAgaW50IHJjPTA7CisgICAgaW50IHIsIHJj OwogICAgIEdDX0lOSVQoY3R4KTsKIAogICAgIGlmIChzY2luZm8tPnRzbGljZV9tcyA8ICBYRU5f U1lTQ1RMX0NTQ0hFRF9UU0xJQ0VfTUlOCiAgICAgICAgIHx8IHNjaW5mby0+dHNsaWNlX21zID4g WEVOX1NZU0NUTF9DU0NIRURfVFNMSUNFX01BWCkgewogICAgICAgICBMT0coRVJST1IsICJUaW1l IHNsaWNlIG91dCBvZiByYW5nZSwgdmFsaWQgcmFuZ2UgaXMgZnJvbSAlZCB0byAlZCIsCiAgICAg ICAgICAgICBYRU5fU1lTQ1RMX0NTQ0hFRF9UU0xJQ0VfTUlOLCBYRU5fU1lTQ1RMX0NTQ0hFRF9U U0xJQ0VfTUFYKTsKLSAgICAgICAgR0NfRlJFRTsKLSAgICAgICAgcmV0dXJuIEVSUk9SX0lOVkFM OworICAgICAgICByYyA9IEVSUk9SX0lOVkFMOworICAgICAgICBnb3RvIG91dDsKICAgICB9CiAg ICAgaWYgKHNjaW5mby0+cmF0ZWxpbWl0X3VzIDwgIFhFTl9TWVNDVExfU0NIRURfUkFURUxJTUlU X01JTgogICAgICAgICB8fCBzY2luZm8tPnJhdGVsaW1pdF91cyA+IFhFTl9TWVNDVExfU0NIRURf UkFURUxJTUlUX01BWCkgewogICAgICAgICBMT0coRVJST1IsICJSYXRlbGltaXQgb3V0IG9mIHJh bmdlLCB2YWxpZCByYW5nZSBpcyBmcm9tICVkIHRvICVkIiwKICAgICAgICAgICAgIFhFTl9TWVND VExfU0NIRURfUkFURUxJTUlUX01JTiwgWEVOX1NZU0NUTF9TQ0hFRF9SQVRFTElNSVRfTUFYKTsK LSAgICAgICAgR0NfRlJFRTsKLSAgICAgICAgcmV0dXJuIEVSUk9SX0lOVkFMOworICAgICAgICBy YyA9IEVSUk9SX0lOVkFMOworICAgICAgICBnb3RvIG91dDsKICAgICB9CiAgICAgaWYgKHNjaW5m by0+cmF0ZWxpbWl0X3VzID4gc2NpbmZvLT50c2xpY2VfbXMqMTAwMCkgewogICAgICAgICBMT0co RVJST1IsICJSYXRlbGltaXQgY2Fubm90IGJlIGdyZWF0ZXIgdGhhbiB0aW1lc2xpY2UiKTsKLSAg ICAgICAgR0NfRlJFRTsKLSAgICAgICAgcmV0dXJuIEVSUk9SX0lOVkFMOworICAgICAgICByYyA9 IEVSUk9SX0lOVkFMOworICAgICAgICBnb3RvIG91dDsKICAgICB9CiAKICAgICBzcGFyYW0udHNs aWNlX21zID0gc2NpbmZvLT50c2xpY2VfbXM7CiAgICAgc3BhcmFtLnJhdGVsaW1pdF91cyA9IHNj aW5mby0+cmF0ZWxpbWl0X3VzOwogCi0gICAgcmMgPSB4Y19zY2hlZF9jcmVkaXRfcGFyYW1zX3Nl dChjdHgtPnhjaCwgcG9vbGlkLCAmc3BhcmFtKTsKLSAgICBpZiAoIHJjIDwgMCApIHsKLSAgICAg ICAgTE9HRShFUlJPUiwgInNldHRpbmcgc2NoZWQgY3JlZGl0IHBhcmFtIik7Ci0gICAgICAgIEdD X0ZSRUU7Ci0gICAgICAgIHJldHVybiBFUlJPUl9GQUlMOworICAgIHIgPSB4Y19zY2hlZF9jcmVk aXRfcGFyYW1zX3NldChjdHgtPnhjaCwgcG9vbGlkLCAmc3BhcmFtKTsKKyAgICBpZiAoIHIgPCAw ICkgeworICAgICAgICBMT0dFKEVSUk9SLCAiU2V0dGluZyBDcmVkaXQgc2NoZWR1bGVyIHBhcmFt ZXRlcnMiKTsKKyAgICAgICAgcmMgPSBFUlJPUl9GQUlMOworICAgICAgICBnb3RvIG91dDsKICAg ICB9CiAKICAgICBzY2luZm8tPnRzbGljZV9tcyA9IHNwYXJhbS50c2xpY2VfbXM7CiAgICAgc2Np bmZvLT5yYXRlbGltaXRfdXMgPSBzcGFyYW0ucmF0ZWxpbWl0X3VzOwogCisgICAgcmMgPSAwOwor IG91dDoKICAgICBHQ19GUkVFOwotICAgIHJldHVybiAwOworICAgIHJldHVybiByYzsKIH0KIAog c3RhdGljIGludCBzY2hlZF9jcmVkaXQyX2RvbWFpbl9nZXQobGlieGxfX2djICpnYywgdWludDMy X3QgZG9taWQsCg== --=-ix8Zske1mzK82139b0YZ-- --=-Tk+WEjp52Y47dcdZNOpq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJX7lTgAAoJEBZCeImluHPuV20P/0uCQyCH871iV/t9Azy8m+jD DiQ/l9/QlvQ3o2F8Ymn1pCBTCIGqiHO2MEdqxwxNWqalDqeTIz7yq22pemmeyMM9 /CEsKvj8LSyGvOCHQsKFQ05B0Kc3RhwlBsgW2qejPIpfAeYHHd0hI7P9TwtxbGiL IaOgsUOfnWzso8pmWuXzAcGtX1OBTPEiMsnWQp/30ckApIh9bFTuvWZ5jVc4CkXa PchUI8J5SgpP3V1mwBsCcpkUIIQeWTpyzOmuWuLux5AZGLY10m22yN9sxGueG4lx 81s4jN8m3XvXeI4xie2Mk4EMT2CpZu4yaAoLU+ifvW137mh+gYWvO5O13dD1hFbW y9BuEVASzOt86o0iGDQasEA1lR3hrfeT4xtgV8ZP1T0b7yih3ml+DIrbah/OeXeu HPzFEVwh/rV5KJef3pGhKkZfjO1QwUqTY73uTDu+cznQkGVmtYn1DAWHp6MkAnbK Te02pmY+ZOFmXHy2mFzXzeM8XeuL90gMaHNJcZSz0Aay55+w00M4xnvidP30UOl0 SmXuL/POuSk5Y6pZxO3FuvxhCDlCg2q75HipUta9NUbknTlDvGwg2pB4F8GjzQb+ 2FkY6YY4xEW1qiCPKlavz+b52DTGyAzboasNwzj2yC5D1kIqNq5MFdCrZlzNH5dE jYb9AfMUiODRCv9Q/kIf =vbgh -----END PGP SIGNATURE----- --=-Tk+WEjp52Y47dcdZNOpq-- --===============0170519186373125617== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0170519186373125617==--