xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 3/4] host allocation: Dedupe "other hosts" flights in duration estimation
Date: Tue,  4 Oct 2016 18:17:43 +0000	[thread overview]
Message-ID: <1475605064-18326-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1475605064-18326-1-git-send-email-ian.jackson@eu.citrix.com>

The old query would return one row for each step in each relevant
flight.  But we are really only interested in the flight.

Group by the flight and sort on max(finished).

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/Executive.pm |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 69f0319..c82a9c7 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -1051,14 +1051,16 @@ sub duration_estimator ($$;$$) {
 END
 
     my $duration_anyref_q= $dbh_tests->prepare(<<END);
-            SELECT f.flight AS flight
+            SELECT f.flight AS flight,
+                   max(s.finished) AS max_finished
 		      FROM steps s JOIN flights f
 		        ON s.flight=f.flight
 		     WHERE s.job=? AND f.blessing=? AND f.branch=?
                        AND s.finished IS NOT NULL
                        AND f.started IS NOT NULL
                        AND f.started >= ?
-                     ORDER BY s.finished DESC
+                     GROUP BY f.flight
+                     ORDER BY max_finished DESC
 END
     # s J J J # fix perl-mode
 
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-10-04 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 18:17 [OSSTEST PATCH 1/4] host allocation: Support -B<blessing> option Ian Jackson
2016-10-04 18:17 ` [OSSTEST PATCH 2/4] host allocation: Pass a debug function in find_recent_duration Ian Jackson
2016-10-04 18:17 ` Ian Jackson [this message]
2016-10-04 18:17 ` [OSSTEST PATCH 4/4] host allocation: Fix duration estimate to not include host allocation Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475605064-18326-3-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).