From: Feng Wu <feng.wu@intel.com>
To: xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, Feng Wu <feng.wu@intel.com>,
george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
dario.faggioli@citrix.com, jbeulich@suse.com
Subject: [PATCH v5 6/7] VT-d: Some cleanups
Date: Tue, 11 Oct 2016 08:57:52 +0800 [thread overview]
Message-ID: <1476147473-30970-7-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1476147473-30970-1-git-send-email-feng.wu@intel.com>
Use type-safe structure assignment instead of memcpy()
Use sizeof(*iremap_entry)
Signed-off-by: Feng Wu <feng.wu@intel.com>
---
xen/drivers/passthrough/vtd/intremap.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c
index 8dd0373..b6f8d3d 100644
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -183,8 +183,8 @@ static void free_remap_entry(struct iommu *iommu, int index)
GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, index,
iremap_entries, iremap_entry);
- memset(iremap_entry, 0, sizeof(struct iremap_entry));
- iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry));
+ memset(iremap_entry, 0, sizeof(*iremap_entry));
+ iommu_flush_cache_entry(iremap_entry, sizeof(*iremap_entry));
iommu_flush_iec_index(iommu, 0, index);
unmap_vtd_domain_page(iremap_entries);
@@ -310,7 +310,7 @@ static int ioapic_rte_to_remap_entry(struct iommu *iommu,
GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, index,
iremap_entries, iremap_entry);
- memcpy(&new_ire, iremap_entry, sizeof(struct iremap_entry));
+ new_ire = *iremap_entry;
if ( rte_upper )
{
@@ -353,8 +353,8 @@ static int ioapic_rte_to_remap_entry(struct iommu *iommu,
remap_rte->format = 1; /* indicate remap format */
}
- memcpy(iremap_entry, &new_ire, sizeof(struct iremap_entry));
- iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry));
+ *iremap_entry = new_ire;
+ iommu_flush_cache_entry(iremap_entry, sizeof(*iremap_entry));
iommu_flush_iec_index(iommu, 0, index);
unmap_vtd_domain_page(iremap_entries);
@@ -638,7 +638,8 @@ static int msi_msg_to_remap_entry(
GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, index,
iremap_entries, iremap_entry);
- memcpy(&new_ire, iremap_entry, sizeof(struct iremap_entry));
+ if ( iremap_entry->remap.p )
+ new_ire.remap.im = iremap_entry->remap.im;
/* Set interrupt remapping table entry */
new_ire.remap.fpd = 0;
@@ -682,8 +683,8 @@ static int msi_msg_to_remap_entry(
if ( !pi_can_suppress_irte_update(&new_ire, iremap_entry) )
{
- memcpy(iremap_entry, &new_ire, sizeof(struct iremap_entry));
- iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry));
+ *iremap_entry = new_ire;
+ iommu_flush_cache_entry(iremap_entry, sizeof(*iremap_entry));
iommu_flush_iec_index(iommu, 0, index);
}
--
2.1.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-11 0:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 0:57 [PATCH v5 0/7] VMX: Properly handle pi descriptor and per-cpu blocking list Feng Wu
2016-10-11 0:57 ` [PATCH v5 1/7] VMX: Statically assign two PI hooks Feng Wu
2016-10-11 8:11 ` Tian, Kevin
2016-10-12 13:25 ` Jan Beulich
2016-10-11 0:57 ` [PATCH v5 2/7] VMX: Properly handle pi when all the assigned devices are removed Feng Wu
2016-10-11 8:20 ` Tian, Kevin
2016-10-11 0:57 ` [PATCH v5 3/7] VMX: Cleanup PI per-cpu blocking list when vcpu is destroyed Feng Wu
2016-10-11 0:57 ` [PATCH v5 4/7] VMX: Make sure PI is in proper state before install the hooks Feng Wu
2016-10-12 13:45 ` Jan Beulich
2016-10-17 6:26 ` Wu, Feng
2016-10-24 7:22 ` Jan Beulich
2016-10-24 7:45 ` Wu, Feng
2016-10-24 7:59 ` Jan Beulich
2016-10-11 0:57 ` [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE Feng Wu
2016-10-12 13:56 ` Jan Beulich
2016-10-17 7:02 ` Wu, Feng
2016-10-24 7:27 ` Jan Beulich
2016-10-24 8:57 ` Wu, Feng
2016-10-24 9:53 ` Jan Beulich
2016-10-24 10:18 ` Wu, Feng
2016-10-24 10:57 ` Jan Beulich
2016-10-24 11:10 ` Wu, Feng
2016-10-24 11:31 ` Jan Beulich
2016-10-25 1:04 ` Wu, Feng
2016-10-25 5:57 ` Tian, Kevin
2016-10-25 8:09 ` Jan Beulich
2016-10-26 9:12 ` Wu, Feng
2016-10-26 9:51 ` Jan Beulich
2016-10-11 0:57 ` Feng Wu [this message]
2016-10-12 14:01 ` [PATCH v5 6/7] VT-d: Some cleanups Jan Beulich
2016-10-11 0:57 ` [PATCH v5 7/7] VMX: Fixup PI descriptor when cpu is offline Feng Wu
2016-10-11 8:38 ` Tian, Kevin
2016-10-11 11:46 ` Wu, Feng
2016-10-11 8:08 ` [PATCH v5 0/7] VMX: Properly handle pi descriptor and per-cpu blocking list Tian, Kevin
2016-10-11 8:11 ` Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476147473-30970-7-git-send-email-feng.wu@intel.com \
--to=feng.wu@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).